This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Makes IOS dispatch showOnCcreen action for header semantics nodes#19788
Merged
chunhtai merged 3 commits intoflutter:masterfrom Jul 16, 2020
Merged
Makes IOS dispatch showOnCcreen action for header semantics nodes#19788chunhtai merged 3 commits intoflutter:masterfrom
chunhtai merged 3 commits intoflutter:masterfrom
Conversation
gaaclarke
approved these changes
Jul 16, 2020
Member
gaaclarke
left a comment
There was a problem hiding this comment.
Code looks good to me. One niggle I have is that SemanticsFlags doesn't have any docstrings so it's hard for me to read this code and know that the logic is correct. Is the documentation somewhere in framework? It would be nice to have it also in flutter/lib/ui/semantics.dart, or have a link to the documentation in the framework.
Contributor
Author
|
I do see doc string in Line 277 in ae4ecbf Is there some more specific you are looking for? |
Member
|
@chunhtai Yea, nowhere is "kIsHeader" defined. The enum is described in general but the fields aren't described. |
Contributor
Author
|
It is defined underneath Line 399 in ae4ecbf |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IOS relies on show on screen action to scroll the app during accessibility focus traversal. This pr makes sure the header always get scrolled if it is focused.
Related Issues
Fixes flutter/flutter#61360
Tests
I added the following tests:
see files
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.