[web] add CanvasKit to CIPD; make it a DEPS dependency; add a manual roller script#28056
[web] add CanvasKit to CIPD; make it a DEPS dependency; add a manual roller script#28056yjbanov merged 6 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| const String canvasKitBaseUrl = String.fromEnvironment( | ||
| 'FLUTTER_WEB_CANVASKIT_URL', | ||
| defaultValue: 'https://unpkg.com/canvaskit-wasm@0.28.1/bin/', | ||
| defaultValue: 'https://unpkg.com/canvaskit-wasm@$canvaskitVersion/bin/', |
There was a problem hiding this comment.
FYI @jacob314 you will probably need to update the devtools code that reads the version from here
There was a problem hiding this comment.
Can devtools read it from canvaskit_lock.yaml?
There was a problem hiding this comment.
Thanks for confirming!
… manual roller script (flutter/engine#28056)
… manual roller script (flutter/engine#28056)
… manual roller script (flutter/engine#28056)
… manual roller script (flutter/engine#28056)
…roller script (flutter#28056) add CanvasKit to CIPD; make it a DEPS dependency; add a manual roller script
This PR does not change how the engine loads CanvasKit. It is still loaded from unpkg.com by default. The loading logic will be updated in a follow-up PR.