Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[iOS] Add FlutterViewController weak pointer check before use#31008

Merged
fluttergithubbot merged 3 commits intoflutter:mainfrom
zhongwuzw:add_weak_ptr_check
Feb 4, 2022
Merged

[iOS] Add FlutterViewController weak pointer check before use#31008
fluttergithubbot merged 3 commits intoflutter:mainfrom
zhongwuzw:add_weak_ptr_check

Conversation

@zhongwuzw
Copy link
Copy Markdown
Member

Weak ptr should be checked for validity before use. Let's add it for protection~

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@zhongwuzw zhongwuzw added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 4, 2022
@fluttergithubbot fluttergithubbot merged commit 23c2bd6 into flutter:main Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants