Skip to content

Update Cupertino examples and add missing tests#103128

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
NevercodeHQ:update_cupertino_examples_2
May 7, 2022
Merged

Update Cupertino examples and add missing tests#103128
fluttergithubbot merged 4 commits intoflutter:masterfrom
NevercodeHQ:update_cupertino_examples_2

Conversation

@TahaTesser
Copy link
Copy Markdown
Contributor

@TahaTesser TahaTesser commented May 5, 2022

part of #72926

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 5, 2022
@TahaTesser TahaTesser requested a review from guidezpl May 5, 2022 12:36
@TahaTesser TahaTesser force-pushed the update_cupertino_examples_2 branch from 1696e4e to 02d1c10 Compare May 6, 2022 09:27
@guidezpl
Copy link
Copy Markdown
Member

guidezpl commented May 6, 2022

Got the tests started

@TahaTesser
Copy link
Copy Markdown
Contributor Author

TahaTesser commented May 6, 2022

Got the tests started

Thanks!

@fluttergithubbot fluttergithubbot merged commit 803f995 into flutter:master May 7, 2022
@TahaTesser TahaTesser deleted the update_cupertino_examples_2 branch May 7, 2022 07:36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2022
@engine-flutter-autoroll
803f995 Update Cupertino examples and add missing tests (flutter/flut…
b1c7455 
…ter#103128)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 7, 2022
@engine-flutter-autoroll
803f995 Update Cupertino examples and add missing tests (flutter/flut…
120a0c5 
…ter#103128)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 7, 2022
@engine-flutter-autoroll
803f995 Update Cupertino examples and add missing tests (flutter/flut…
9bbc85d 
…ter#103128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @guidezpl @fluttergithubbot