Skip to content

Support for dismissDirection property in SnackBarTheme#139068

Merged
auto-submit[bot] merged 9 commits intoflutter:masterfrom
shanmugamaasil:b139012
Dec 5, 2023
Merged

Support for dismissDirection property in SnackBarTheme#139068
auto-submit[bot] merged 9 commits intoflutter:masterfrom
shanmugamaasil:b139012

Conversation

@shanmugamaasil
Copy link
Copy Markdown
Contributor

@shanmugamaasil shanmugamaasil commented Nov 27, 2023

This PR introduces a new feature that allows users to configure the 'dismissDirection' in SnackBarTheme. This enhancement provides users with the flexibility to set the 'dismissDirection' property in the ThemeData, rather than having to apply it each time when initializing a snack bar. This streamlines the process and makes it more convenient for users to manage and customize the behavior of snack bars within their applications.

Fixes #139012

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 27, 2023
QuncCccccc
QuncCccccc reviewed Dec 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks so much for the contribution! Just need to fix the failed tests, then we are good to go!

QuncCccccc
QuncCccccc approved these changes Dec 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MitchellGoodwin
MitchellGoodwin approved these changes Dec 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 5, 2023
@auto-submit auto-submit bot merged commit af61c6c into flutter:master Dec 5, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
4543ba6 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
e49466d 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
b31bcd4 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
d98017e 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
c3befb2 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
2c1031d 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
addf458 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
85f347e 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
0265469 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
ddfedd1 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
a25f2bb 
…er/flutter#139068)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
daa70ef 
…er/flutter#139068)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
4960edb 
…er/flutter#139068)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
7de02bb 
…er/flutter#139068)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
ab1a682 
…er/flutter#139068)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
4e9f750 
…er/flutter#139068)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
9bc9ae3 
…er/flutter#139068)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
adcda02 
…er/flutter#139068)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
a5d52ae 
…er/flutter#139068)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
a76574e 
…er/flutter#139068)
@HansMuller HansMuller mentioned this pull request Dec 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
af61c6c Support for dismissDirection property in SnackBarTheme (flutt…
0da9945 
…er/flutter#139068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

+1 more reviewer

@MitchellGoodwin MitchellGoodwin MitchellGoodwin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support DismissDirection in SnackBarThemeData

3 participants

@shanmugamaasil @QuncCccccc @MitchellGoodwin