fix: use double quotes in settings.gradle.kts template by ishaquehassan · Pull Request #183081 · flutter/flutter

ishaquehassan · 2026-03-01T07:17:55Z

The settings.gradle.kts.tmpl template for Android plugins was using single quotes for string literals. Kotlin requires double quotes (") for string literals, while single quotes (') are only valid for character literals. This was introduced when the file was renamed from settings.gradle to settings.gradle.kts in PR #173993, but the string format was not updated from Groovy style to Kotlin style.

This PR changes:

// Before (invalid Kotlin)
rootProject.name = '{{projectName}}'

// After (valid Kotlin)
rootProject.name = "{{projectName}}"

Fixes #182962

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

This PR is test-exempt because it modifies a template file that generates valid Kotlin syntax. The fix is a single-character change from single quotes to double quotes, which is a syntactic correction that does not require behavioral testing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Kotlin requires double quotes for string literals, not single quotes. The settings.gradle.kts.tmpl template was using single quotes which is invalid Kotlin syntax. Fixes flutter#182962

flutter-dashboard · 2026-03-01T07:17:58Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request updates the settings.gradle.kts.tmpl template file, changing the single quotes used for the projectName template variable to double quotes. This change ensures the generated settings.gradle.kts file has valid Kotlin syntax for string literals.

mboetger · 2026-03-03T18:52:27Z

@ishaquehassan - Thank you for the PR.

ishaquehassan · 2026-03-03T21:20:16Z

@mboetger - Thank you for the review and approval! Really appreciate it.

auto-submit · 2026-03-03T22:22:15Z

autosubmit label was removed for flutter/flutter/183081, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

ishaquehassan · 2026-03-04T18:41:55Z

@mboetger can you assign another relevant reviewer to it?

auto-submit · 2026-03-04T19:15:25Z

autosubmit label was removed for flutter/flutter/183081, because - The status or check suite Linux web_skwasm_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.

ishaquehassan · 2026-03-05T03:23:34Z

autosubmit label was removed for flutter/flutter/183081, because - The status or check suite Linux web_skwasm_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.

its resolved! @gmackall @mboetger can you guys re-apply the autosubmit

ishaquehassan · 2026-03-05T17:05:54Z

@gmackall the CI issue has been resolved. Could you re-apply the autosubmit label when you get a chance? All checks are green now.

…tter/flutter#183081)

Roll Flutter from d3dd7744e81f to d18214307703 (33 revisions) flutter/flutter@d3dd774...d182143 2026-03-06 [email protected] Roll Packages from 8d5c5cd to fe3de64 (2 revisions) (flutter/flutter#183308) 2026-03-06 [email protected] Roll Dart SDK from 1b51451cdb99 to 7c7c1e3d024d (2 revisions) (flutter/flutter#183294) 2026-03-06 [email protected] Roll Dart SDK from 9ac06cdd1801 to 1b51451cdb99 (9 revisions) (flutter/flutter#183289) 2026-03-06 [email protected] Add GitHub workflows to assist with release tasks (flutter/flutter#181978) 2026-03-06 [email protected] [Impeller] Fix new convex path shadow generation in perspective (flutter/flutter#183187) 2026-03-06 [email protected] Roll pub packages (flutter/flutter#183178) 2026-03-05 [email protected] fix: use double quotes in settings.gradle.kts template (flutter/flutter#183081) 2026-03-05 [email protected] Add fallbackColor for PredictiveBackPageTransitionBuilder and PredictiveBackFullscreenPageTransitionBuilder (flutter/flutter#182690) 2026-03-05 [email protected] Simplify TesterContextGLES (multithreading logic not needed), and enable some tests that now pass (flutter/flutter#183250) 2026-03-05 [email protected] Roll Skia from a94df1cdabb0 to a69ef43650ee (14 revisions) (flutter/flutter#183280) 2026-03-05 [email protected] Windowing implementation of `showDialog` that uses a native desktop window to display the content (flutter/flutter#181861) 2026-03-05 [email protected] Build CocoaPod plugin frameworks for Add to App FlutterPluginRegistrant (flutter/flutter#183239) 2026-03-05 [email protected] Extend the Linux web_skwasm_tests_1 timeout to 45 minutes (flutter/flutter#183247) 2026-03-05 [email protected] Update Dart to 3.12 beta 2 (flutter/flutter#183251) 2026-03-05 [email protected] Replace the rest of the references to `flutter/engine` with `flutter/flutter` (flutter/flutter#182938) 2026-03-05 [email protected] chore: convert android_verified_input to pub-workspace (flutter/flutter#183175) 2026-03-05 [email protected] Add await to flutter_test callsites (flutter/flutter#182983) 2026-03-05 [email protected] [iOS] Skip gesture recognizer reset workaround on iOS 26+ (flutter/flutter#183186) 2026-03-05 [email protected] Add warning for plugins not migrated to UIScene (flutter/flutter#182826) 2026-03-05 [email protected] Roll Fuchsia Linux SDK from JJw5EJ87vLGqFVl4h... to 8ay15_eQOEgPHCypm... (flutter/flutter#183255) 2026-03-05 [email protected] Roll Skia from ada0b7628c79 to a94df1cdabb0 (2 revisions) (flutter/flutter#183249) 2026-03-05 [email protected] Roll Packages from 82baf93 to 8d5c5cd (2 revisions) (flutter/flutter#183269) 2026-03-05 [email protected] Add `UnlabaledLeafNodeEvaluation` (flutter/flutter#182872) 2026-03-04 [email protected] Re-specify the ndk version in various test apps, to prevent ndk download (flutter/flutter#183134) 2026-03-04 [email protected] Eliminate rebuilds for Scaffold FAB animation (flutter/flutter#182331) 2026-03-04 [email protected] Add Michal Kucharski to AUTHORS (flutter/flutter#182366) 2026-03-04 [email protected] Merge changelog from 3.41.4 stable. (flutter/flutter#183243) 2026-03-04 [email protected] Allow stylus support on windows (flutter/flutter#165323) 2026-03-04 [email protected] Fix docs on SingletonFlutterWindow.supportsShowingSystemContextMenu (flutter/flutter#183142) 2026-03-04 [email protected] Roll Packages from 9083bc9 to 82baf93 (5 revisions) (flutter/flutter#183240) 2026-03-04 [email protected] Fixes FocusHighlightMode on Android when typing in software keyboard (flutter/flutter#180753) 2026-03-04 [email protected] Make compileShader() retry without sksl if it fails with sksl. (flutter/flutter#183146) 2026-03-04 [email protected] [web] Use pointer-events: auto for non-interactive leaf semantics nodes (flutter/flutter#183077) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

The `settings.gradle.kts.tmpl` template for Android plugins was using single quotes for string literals. Kotlin requires double quotes (`"`) for string literals, while single quotes (`'`) are only valid for character literals. This was introduced when the file was renamed from `settings.gradle` to `settings.gradle.kts` in PR flutter#173993, but the string format was not updated from Groovy style to Kotlin style. This PR changes: ```kotlin // Before (invalid Kotlin) rootProject.name = '{{projectName}}' // After (valid Kotlin) rootProject.name = "{{projectName}}" ``` Fixes flutter#182962 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. This PR is [test-exempt] because it modifies a template file that generates valid Kotlin syntax. The fix is a single-character change from single quotes to double quotes, which is a syntactic correction that does not require behavioral testing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…r#11191) Roll Flutter from d3dd7744e81f to d18214307703 (33 revisions) flutter/flutter@d3dd774...d182143 2026-03-06 [email protected] Roll Packages from 8d5c5cd to fe3de64 (2 revisions) (flutter/flutter#183308) 2026-03-06 [email protected] Roll Dart SDK from 1b51451cdb99 to 7c7c1e3d024d (2 revisions) (flutter/flutter#183294) 2026-03-06 [email protected] Roll Dart SDK from 9ac06cdd1801 to 1b51451cdb99 (9 revisions) (flutter/flutter#183289) 2026-03-06 [email protected] Add GitHub workflows to assist with release tasks (flutter/flutter#181978) 2026-03-06 [email protected] [Impeller] Fix new convex path shadow generation in perspective (flutter/flutter#183187) 2026-03-06 [email protected] Roll pub packages (flutter/flutter#183178) 2026-03-05 [email protected] fix: use double quotes in settings.gradle.kts template (flutter/flutter#183081) 2026-03-05 [email protected] Add fallbackColor for PredictiveBackPageTransitionBuilder and PredictiveBackFullscreenPageTransitionBuilder (flutter/flutter#182690) 2026-03-05 [email protected] Simplify TesterContextGLES (multithreading logic not needed), and enable some tests that now pass (flutter/flutter#183250) 2026-03-05 [email protected] Roll Skia from a94df1cdabb0 to a69ef43650ee (14 revisions) (flutter/flutter#183280) 2026-03-05 [email protected] Windowing implementation of `showDialog` that uses a native desktop window to display the content (flutter/flutter#181861) 2026-03-05 [email protected] Build CocoaPod plugin frameworks for Add to App FlutterPluginRegistrant (flutter/flutter#183239) 2026-03-05 [email protected] Extend the Linux web_skwasm_tests_1 timeout to 45 minutes (flutter/flutter#183247) 2026-03-05 [email protected] Update Dart to 3.12 beta 2 (flutter/flutter#183251) 2026-03-05 [email protected] Replace the rest of the references to `flutter/engine` with `flutter/flutter` (flutter/flutter#182938) 2026-03-05 [email protected] chore: convert android_verified_input to pub-workspace (flutter/flutter#183175) 2026-03-05 [email protected] Add await to flutter_test callsites (flutter/flutter#182983) 2026-03-05 [email protected] [iOS] Skip gesture recognizer reset workaround on iOS 26+ (flutter/flutter#183186) 2026-03-05 [email protected] Add warning for plugins not migrated to UIScene (flutter/flutter#182826) 2026-03-05 [email protected] Roll Fuchsia Linux SDK from JJw5EJ87vLGqFVl4h... to 8ay15_eQOEgPHCypm... (flutter/flutter#183255) 2026-03-05 [email protected] Roll Skia from ada0b7628c79 to a94df1cdabb0 (2 revisions) (flutter/flutter#183249) 2026-03-05 [email protected] Roll Packages from 82baf93 to 8d5c5cd (2 revisions) (flutter/flutter#183269) 2026-03-05 [email protected] Add `UnlabaledLeafNodeEvaluation` (flutter/flutter#182872) 2026-03-04 [email protected] Re-specify the ndk version in various test apps, to prevent ndk download (flutter/flutter#183134) 2026-03-04 [email protected] Eliminate rebuilds for Scaffold FAB animation (flutter/flutter#182331) 2026-03-04 [email protected] Add Michal Kucharski to AUTHORS (flutter/flutter#182366) 2026-03-04 [email protected] Merge changelog from 3.41.4 stable. (flutter/flutter#183243) 2026-03-04 [email protected] Allow stylus support on windows (flutter/flutter#165323) 2026-03-04 [email protected] Fix docs on SingletonFlutterWindow.supportsShowingSystemContextMenu (flutter/flutter#183142) 2026-03-04 [email protected] Roll Packages from 9083bc9 to 82baf93 (5 revisions) (flutter/flutter#183240) 2026-03-04 [email protected] Fixes FocusHighlightMode on Android when typing in software keyboard (flutter/flutter#180753) 2026-03-04 [email protected] Make compileShader() retry without sksl if it fails with sksl. (flutter/flutter#183146) 2026-03-04 [email protected] [web] Use pointer-events: auto for non-interactive leaf semantics nodes (flutter/flutter#183077) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

The `settings.gradle.kts.tmpl` template for Android plugins was using single quotes for string literals. Kotlin requires double quotes (`"`) for string literals, while single quotes (`'`) are only valid for character literals. This was introduced when the file was renamed from `settings.gradle` to `settings.gradle.kts` in PR flutter#173993, but the string format was not updated from Groovy style to Kotlin style. This PR changes: ```kotlin // Before (invalid Kotlin) rootProject.name = '{{projectName}}' // After (valid Kotlin) rootProject.name = "{{projectName}}" ``` Fixes flutter#182962 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. This PR is [test-exempt] because it modifies a template file that generates valid Kotlin syntax. The fix is a single-character change from single quotes to double quotes, which is a syntactic correction that does not require behavioral testing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

fix: use double quotes in settings.gradle.kts template

c20b789

Kotlin requires double quotes for string literals, not single quotes. The settings.gradle.kts.tmpl template was using single quotes which is invalid Kotlin syntax. Fixes flutter#182962

ishaquehassan requested a review from a team as a code owner March 1, 2026 07:17

github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. team-android Owned by Android platform team labels Mar 1, 2026

gemini-code-assist Bot reviewed Mar 1, 2026

View reviewed changes

ishaquehassan added 2 commits March 2, 2026 15:05

Merge branch 'master' into fix/182962-gradle-kts-string-format

687e9a5

Merge branch 'master' into fix/182962-gradle-kts-string-format

a4d0a28

mboetger approved these changes Mar 3, 2026

View reviewed changes

Merge branch 'master' into fix/182962-gradle-kts-string-format

bf00bd0

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2026

ishaquehassan added 3 commits March 4, 2026 11:02

Merge branch 'master' into fix/182962-gradle-kts-string-format

df54528

Merge branch 'master' into fix/182962-gradle-kts-string-format

1c1b6ea

Merge branch 'master' into fix/182962-gradle-kts-string-format

df10cc0

gmackall approved these changes Mar 4, 2026

View reviewed changes

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2026

Merge branch 'master' into fix/182962-gradle-kts-string-format

a6fb5ea

Merge branch 'master' into fix/182962-gradle-kts-string-format

e8ad278

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 5, 2026

Merge branch 'master' into fix/182962-gradle-kts-string-format

0bc3976

auto-submit Bot added this pull request to the merge queue Mar 5, 2026

Merged via the queue into flutter:master with commit 71825c3 Mar 6, 2026
145 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2026

engine-flutter-autoroll mentioned this pull request Mar 6, 2026

Roll Flutter from d3dd7744e81f to 7a95d24e493a (32 revisions) flutter/packages#11190

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2026

71825c303 fix: use double quotes in settings.gradle.kts template (flu…

e491a92

…tter/flutter#183081)

engine-flutter-autoroll mentioned this pull request Mar 6, 2026

Roll Flutter from d3dd7744e81f to d18214307703 (33 revisions) flutter/packages#11191

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2026

71825c303 fix: use double quotes in settings.gradle.kts template (flu…

b39eabe

…tter/flutter#183081)

Piinks mentioned this pull request Mar 6, 2026

Flutter Notable Commits - 2026 #181433

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use double quotes in settings.gradle.kts template#183081

fix: use double quotes in settings.gradle.kts template#183081
auto-submit[bot] merged 10 commits intoflutter:masterfrom
ishaquehassan:fix/182962-gradle-kts-string-format

ishaquehassan commented Mar 1, 2026

Uh oh!

flutter-dashboard Bot commented Mar 1, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

mboetger commented Mar 3, 2026

Uh oh!

ishaquehassan commented Mar 3, 2026

Uh oh!

auto-submit Bot commented Mar 3, 2026

Uh oh!

ishaquehassan commented Mar 4, 2026

Uh oh!

auto-submit Bot commented Mar 4, 2026

Uh oh!

ishaquehassan commented Mar 5, 2026 •

edited

Loading

Uh oh!

ishaquehassan commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ishaquehassan commented Mar 1, 2026

Pre-launch Checklist

Uh oh!

flutter-dashboard Bot commented Mar 1, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

mboetger commented Mar 3, 2026

Uh oh!

ishaquehassan commented Mar 3, 2026

Uh oh!

auto-submit Bot commented Mar 3, 2026

Uh oh!

ishaquehassan commented Mar 4, 2026

Uh oh!

auto-submit Bot commented Mar 4, 2026

Uh oh!

ishaquehassan commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishaquehassan commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ishaquehassan commented Mar 5, 2026 •

edited

Loading