Skip to content

use RadioListTile in expansion panels demo#20240

Merged
jslavitz merged 2 commits intoflutter:masterfrom
mockturtl:fix-6048-expansion-panels
Oct 2, 2018
Merged

use RadioListTile in expansion panels demo#20240
jslavitz merged 2 commits intoflutter:masterfrom
mockturtl:fix-6048-expansion-panels

Conversation

@mockturtl
Copy link
Copy Markdown
Contributor

Fixes #6048.

@Hixie
Copy link
Copy Markdown
Contributor

Hixie commented Aug 28, 2018

This fix is good. Thanks for your contribution! Might make sense to add a test to make sure the original issue is gone too (i.e. tap the text, check the value changes). Would you mind doing that?

@mockturtl mockturtl force-pushed the fix-6048-expansion-panels branch from 4ae6c3e to f280395 Compare September 5, 2018 02:28
@mockturtl
Copy link
Copy Markdown
Contributor Author

An existing RadioListTile test verifies that onChanged is called by both a label and a radio tap. I added a test to verify the new selection after a rebuild.

My logic for getting find to match a Radio<_T> feels awkward. Do you see a less clunky approach?

@mockturtl mockturtl force-pushed the fix-6048-expansion-panels branch 2 times, most recently from b58eaa3 to 2f1571b Compare September 15, 2018 13:53
@mockturtl mockturtl force-pushed the fix-6048-expansion-panels branch from 2f1571b to b4dd84c Compare September 24, 2018 18:47
@jslavitz
Copy link
Copy Markdown
Contributor

@Hixie Anything else needed to get this one through?

@mockturtl mockturtl force-pushed the fix-6048-expansion-panels branch 2 times, most recently from e7232a3 to eaddd5f Compare October 1, 2018 19:44
@mockturtl mockturtl force-pushed the fix-6048-expansion-panels branch from eaddd5f to c1eafc6 Compare October 1, 2018 19:50
- expose `_Location`
- appease analyzer
@mockturtl
Copy link
Copy Markdown
Contributor Author

@jslavitz @Hixie Is there anything I can do to help besides keeping the changes up to date with master?

@Hixie
Copy link
Copy Markdown
Contributor

Hixie commented Oct 1, 2018

LGTM

@jslavitz jslavitz merged commit 13684e4 into flutter:master Oct 2, 2018
jonahwilliams pushed a commit that referenced this pull request Oct 2, 2018
@mockturtl mockturtl deleted the fix-6048-expansion-panels branch October 2, 2018 20:48
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expansion panels: Can't tap radio labels in Location

4 participants