[Material] Add TabBarTheme #22012
Conversation
|
Note: goldens added in flutter/goldens@26b603d, although I still have failing tests around goldens so I don't think I did it quite right. |
There was a problem hiding this comment.
Is RenderParagraph as high as you can go? Text or RichText don't work?
There was a problem hiding this comment.
Text doesn't work because it doesn't have a color property, at one point I got it working with RichText, but jacob made an interesting point, that that the RenderObject is a better "source of truth" for something like this, since what we care about is what color gets painted, not as much what the intermediate style properties are. WDYT about that?
There was a problem hiding this comment.
Makes sense! Run by Hans.
There was a problem hiding this comment.
Using the RenderParagraph object here makes sense.
You can get it like this:
final RenderParagaph renderObject = tester.renderObject<RenderParagraph>(find.text(_tab1Text));
There was a problem hiding this comment.
Also: check the icon color
|
Committed changes addressing comments: @willlarche PTAL |
|
LGTM. Please have Hans review and resolve tests. |
|
Tests are passing and Will's feedback is incorporated. @HansMuller PTAL! |
HansMuller
left a comment
There was a problem hiding this comment.
This looks pretty good. Feedback is mostly small-stuff .
There was a problem hiding this comment.
Also: check the icon color
|
@HansMuller I have incorporated the changes you suggested, PTAL when you get a chance! |
HansMuller
left a comment
There was a problem hiding this comment.
LGTM.
The last couple of comments are just some random formatting suggestions, no biggie.
Really replacing the 40 other occurrences of the lerp doc boilerplate would be a good thing to do for a quick follow-on PR.
a8e2446 to
67e4a2a
Compare
Feature - This will allow us to create/use custom themes for
TabBars