Update the golden image comparator to handle read-only image ByteData views#61406
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Jul 14, 2020
Merged
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
nturgut
approved these changes
Jul 14, 2020
Contributor
nturgut
left a comment
There was a problem hiding this comment.
LGTM to unblock the roll.
… views The engine is now wrapping image byte data in an UnmodifiableByteDataView (see flutter/engine#19504). The golden image comparator must make a copy before modifying the buffer.
290bf59 to
11e5d3d
Compare
zanderso
approved these changes
Jul 14, 2020
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine is now wrapping image byte data in an UnmodifiableByteDataView
(see flutter/engine#19504). The golden image
comparator must make a copy before modifying the buffer.