Skip to content

Fix Local SwitchTheme not being inherited by Switch Widget#97705

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_local_switch_theme
Feb 3, 2022
Merged

Fix Local SwitchTheme not being inherited by Switch Widget#97705
fluttergithubbot merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_local_switch_theme

Conversation

@TahaTesser
Copy link
Copy Markdown
Contributor

@TahaTesser TahaTesser commented Feb 3, 2022 •
edited
Loading

Complete details in #97691 (comment)
Related #97691

This PR matches

flutter/packages/flutter/lib/src/material/toggle_buttons.dart

Lines 900 to 902 in 6aed693

final ThemeData theme = Theme.of(context);
final ToggleButtonsThemeData toggleButtonsTheme = ToggleButtonsTheme.of(context);

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 3, 2022
@TahaTesser TahaTesser requested a review from goderbauer February 3, 2022 16:09
goderbauer
goderbauer approved these changes Feb 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser
Copy link
Copy Markdown
Contributor Author

TahaTesser commented Feb 3, 2022

@goderbauer
Thanks! I've made same fix for other two widgets with the same problem
#97715
#97713

@fluttergithubbot fluttergithubbot merged commit 3bba8df into flutter:master Feb 3, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
40cca46 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
a08be19 
flutter/flutter#97705)
This was referenced Feb 3, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
eece89e 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
f7a58f8 
flutter/flutter#97705)
This was referenced Feb 3, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
adf412f 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
b4bc4c0 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
be26ee0 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
6987ee9 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
dc85bf2 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
a91db30 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
a79cfb2 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
f0a750e 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
37e868b 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
846c210 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
c113543 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
ce02a00 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
b228c7d 
flutter/flutter#97705)
This was referenced Feb 6, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
b4a1028 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
f0b6368 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
dc5556c 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
5bc0203 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
5811c2c 
flutter/flutter#97705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
49d5524 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
437853a 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
b1d454f 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
bdb5f87 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
903a9a9 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
7ff6671 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
7e7a685 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
eb327c1 
flutter/flutter#97705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
3bba8df Fix Local SwitchTheme not being inherited by Switch Widget (
7318a42 
flutter/flutter#97705)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @goderbauer @fluttergithubbot