Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Use the common PlatformInterface functionality#2399

Merged
amirh merged 5 commits intoflutter:masterfrom
amirh:url_launcher_use_pi
Dec 11, 2019
Merged

[url_launcher] Use the common PlatformInterface functionality#2399
amirh merged 5 commits intoflutter:masterfrom
amirh:url_launcher_use_pi

Conversation

@amirh
Copy link
Copy Markdown
Contributor

@amirh amirh commented Dec 11, 2019

Description

url_launcher_platform_interface

Replace the current mechanism for protecting against implements with the common PlatformInterface class from the plugin_platform_interface package.

url_launcher

Update the unit test to work with the newly used PlatformInterface.
To keep CI green this includes a path dependency override.

This change is going to land and publish with the following sequence:

  1. land this PR
  2. publish url_launcher_platform_interface
  3. land a PR to remove the dependency override from url_launcher, bump it's dependency on url_launcher_platform_interface, and re-enable the publish check for url_launcher
  4. publish url_launcher

Related Issues

flutter/flutter#43368

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

^ see changelog

@amirh amirh changed the title Url launcher use pi [url_launcher] Update unit test to work with PlatformInterface Dec 11, 2019
@amirh amirh changed the title [url_launcher] Update unit test to work with PlatformInterface [url_launcher] Use the common PlatformInterface functionality Dec 11, 2019
@amirh amirh force-pushed the url_launcher_use_pi branch from 5d059b4 to 1db5056 Compare December 11, 2019 20:13
Copy link
Copy Markdown
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh amirh merged commit 4fc85fb into flutter:master Dec 11, 2019
@amirh amirh deleted the url_launcher_use_pi branch December 11, 2019 21:31
amirh added a commit that referenced this pull request Dec 12, 2019
Follow-up to #2399 removing the dependency override.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
…r#2399)

### url_launcher_platform_interface
Replace the current mechanism for protecting against implements with the common PlatformInterface class from the plugin_platform_interface package.

### url_launcher

Update the unit test to work with the newly used PlatformInterface.
To keep CI green this includes a path dependency override.

This change is going to land and publish with the following sequence:

1. land this PR
2. publish url_launcher_platform_interface
3. land a PR to remove the dependency override from url_launcher, bump it's dependency on url_launcher_platform_interface, and re-enable the publish check for url_launcher
4. publish url_launcher
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants