This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_sign_in] update to androidx#2611
Merged
cyanglaz merged 3 commits intoflutter:masterfrom Mar 19, 2020
Merged
Conversation
blasten
reviewed
Mar 19, 2020
| org.gradle.jvmargs=-Xmx1536M | ||
| android.enableR8=true | ||
| android.useAndroidX=true | ||
| android.enableJetifier=true No newline at end of file |
There was a problem hiding this comment.
nit: EOF here and the other gradle.properties.
blasten
approved these changes
Mar 19, 2020
blasten
left a comment
There was a problem hiding this comment.
LGTM. I was surprised to see some androidx dependencies: https://github.com/flutter/plugins/blob/master/packages/google_sign_in/google_sign_in/example/android/app/build.gradle#L40, but no the corresponding gradle.properties.
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.