Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Migrate to Android v2 embedder.#2624

Merged
cyanglaz merged 26 commits intoflutter:masterfrom
zhenqiu1101:migration
Apr 2, 2020
Merged

[google_sign_in] Migrate to Android v2 embedder.#2624
cyanglaz merged 26 commits intoflutter:masterfrom
zhenqiu1101:migration

Conversation

@zhenqiu1101
Copy link
Copy Markdown
Contributor

@zhenqiu1101 zhenqiu1101 commented Mar 27, 2020

Description

Migrate to Android v2 embedder and keep it backward compatible with v1.

Related Issues

flutter/flutter#41838

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@zhenqiu1101
Copy link
Copy Markdown
Contributor Author

zhenqiu1101 commented Mar 27, 2020 •
edited
Loading

@mehmetf FYI

@mehmetf mehmetf requested a review from cyanglaz March 27, 2020 22:53
@mehmetf
Copy link
Copy Markdown
Contributor

mehmetf commented Mar 27, 2020

Chris, could you review this? This should resolve flutter/flutter#41838.

@cyanglaz
Copy link
Copy Markdown
Contributor

cyanglaz commented Mar 27, 2020

@mehmetf @zhenqiu1101 Sure. Will add it to my list and probably do it on Monday.

cyanglaz
cyanglaz approved these changes Mar 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@cyanglaz cyanglaz self-requested a review March 30, 2020 23:37
@cyanglaz
Copy link
Copy Markdown
Contributor

cyanglaz commented Mar 30, 2020

Just realized that the example app has not migrated in this PR. Please hold off merging.

@cyanglaz
Copy link
Copy Markdown
Contributor

cyanglaz commented Mar 30, 2020

Things that are missing:
Embeddingv1activity
removing MainActivity
updating manifast.xml to use FlutterActivity
Tests for each activities
e2e tests

cyanglaz
cyanglaz reviewed Apr 1, 2020
View reviewed changes
@cyanglaz cyanglaz merged commit 1b317f5 into flutter:master Apr 2, 2020
@cyanglaz cyanglaz mentioned this pull request Apr 2, 2020
Merged
jerryzhoujw pushed a commit to jerryzhoujw/plugins that referenced this pull request Apr 10, 2020
@zhenqiu1101 @jerryzhoujw
[google_sign_in] Migrate to Android v2 embedder. (flutter#2624)
85ed431
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
@zhenqiu1101 @EdwinRomelta
[google_sign_in] Migrate to Android v2 embedder. (flutter#2624)
3e3ed31
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@zhenqiu1101 @jorgefspereira
[google_sign_in] Migrate to Android v2 embedder. (flutter#2624)
b9ce77f
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@zhenqiu1101
[google_sign_in] Migrate to Android v2 embedder. (flutter#2624)
5935481
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhenqiu1101 @mehmetf @cyanglaz @googlebot