This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Only call onWebResourceError for main frame#3078
Merged
fluttergithubbot merged 9 commits intoflutter:masterfrom Aug 10, 2021
Merged
[webview_flutter] Only call onWebResourceError for main frame#3078fluttergithubbot merged 9 commits intoflutter:masterfrom
fluttergithubbot merged 9 commits intoflutter:masterfrom
Conversation
Contributor
|
Looks like this fell through the cracks. Could you add a version bump and resolve the conflict here? Other than that, it looks good to go. |
| ); | ||
|
|
||
| expect(errorCompleter.future, doesNotComplete); | ||
| await Future.delayed(Duration(seconds: 5)); |
Contributor
There was a problem hiding this comment.
I missed this when looking at the PR before; why is there a 5-second sleep at the end of these tests? At the very least this needs a clear comment, but is there really not some reliable thing we can wait for to do whatever this is intended to do, rather than relying on timing?
Contributor
Author
There was a problem hiding this comment.
I think I believed there was a chance for an error to occur after the page finished loading, but I just tested it and that doesn't look like the case for the url provided. I changed it to wait for onPageFinished.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
onWebResourceErroris called only for main frame on iOS and Android version below 23. This makes Android versions 23+ only use this callback for main frame as well.Related Issues
Fixes flutter/flutter#64925
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?