Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[tool] github action to auto publish (skeleton) #3834

Merged
cyanglaz merged 7 commits intoflutter:masterfrom
cyanglaz:release_ga
May 11, 2021
Merged

[tool] github action to auto publish (skeleton) #3834
cyanglaz merged 7 commits intoflutter:masterfrom
cyanglaz:release_ga

Conversation

@cyanglaz
Copy link
Copy Markdown
Contributor

@cyanglaz cyanglaz commented Apr 29, 2021

This is a skeleton github action, this will be integrated with the auto publish tool script once the tool script is ready.

partially flutter/flutter#81446

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Apr 29, 2021
stuartmorgan-g
stuartmorgan-g approved these changes May 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

.github/workflows/release.yml Outdated
fetch-depth: 0 #fetch all history so the tool can get all the tag to determine version.

- name: "Install Flutter"
# Github aciont doesn't support templates so it is hard to share this snippet with another action
Copy link
Copy Markdown
Contributor

@stuartmorgan-g stuartmorgan-g May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions don't support

Copy link
Copy Markdown
Contributor Author

@cyanglaz cyanglaz May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.github/workflows/release.yml Outdated
- name: Checkout code
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
with:
fetch-depth: 0 #fetch all history so the tool can get all the tag to determine version.
Copy link
Copy Markdown
Contributor

@stuartmorgan-g stuartmorgan-g May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: space after # please

Copy link
Copy Markdown
Contributor Author

@cyanglaz cyanglaz May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

cyanglaz
cyanglaz commented May 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan Updated pre review comments, PTAL

.github/workflows/release.yml Outdated
- name: Checkout code
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
with:
fetch-depth: 0 #fetch all history so the tool can get all the tag to determine version.
Copy link
Copy Markdown
Contributor Author

@cyanglaz cyanglaz May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.github/workflows/release.yml Outdated
fetch-depth: 0 #fetch all history so the tool can get all the tag to determine version.

- name: "Install Flutter"
# Github aciont doesn't support templates so it is hard to share this snippet with another action
Copy link
Copy Markdown
Contributor Author

@cyanglaz cyanglaz May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@stuartmorgan-g
Copy link
Copy Markdown
Contributor

stuartmorgan-g commented May 5, 2021

@stuartmorgan Updated pre review comments, PTAL

Still LGTM. (I approved with the previous review.)

@cyanglaz cyanglaz merged commit 145b6cf into flutter:master May 11, 2021
@cyanglaz cyanglaz deleted the release_ga branch May 11, 2021 21:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
145b6cf [tool] github action to auto publish (skeleton) (flutter/plug…
c959ce9 
…ins#3834)
cyanglaz pushed a commit that referenced this pull request May 11, 2021
Revert "[tool] github action to auto publish (skeleton) (#3834)"
7c1454f 
This reverts commit 145b6cf.
@cyanglaz cyanglaz mentioned this pull request May 11, 2021
Merged
cyanglaz pushed a commit that referenced this pull request May 11, 2021
Revert "[tool] github action to auto publish (skeleton) (#3834)" (#3880)
ad5e88f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
145b6cf [tool] github action to auto publish (skeleton) (flutter/plug…
99168cb 
…ins#3834)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
145b6cf [tool] github action to auto publish (skeleton) (flutter/plug…
24e1e59 
…ins#3834)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
145b6cf [tool] github action to auto publish (skeleton) (flutter/plug…
425e338 
…ins#3834)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
145b6cf [tool] github action to auto publish (skeleton) (flutter/plug…
407315f 
…ins#3834)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
145b6cf [tool] github action to auto publish (skeleton) (flutter/plug…
e464c22 
…ins#3834)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
145b6cf [tool] github action to auto publish (skeleton) (flutter/plug…
d208d8d 
…ins#3834)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
145b6cf [tool] github action to auto publish (skeleton) (flutter/plug…
37549e2 
…ins#3834)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@fotiDim
[tool] github action to auto publish (skeleton) (flutter#3834)
57c6c7e
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@fotiDim
Revert "[tool] github action to auto publish (skeleton) (flutter#3834)…
e92a6aa 
…" (flutter#3880)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyanglaz @stuartmorgan-g