Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Fix README example#4220

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
TahaTesser:fix_image_picker_readme
Aug 6, 2021
Merged

[image_picker] Fix README example#4220
fluttergithubbot merged 2 commits intoflutter:masterfrom
TahaTesser:fix_image_picker_readme

Conversation

@TahaTesser
Copy link
Copy Markdown
Contributor

@TahaTesser TahaTesser commented Aug 6, 2021 •
edited
Loading

Fixes flutter/flutter#87634
In the API Docs for pickMultiImage or code sample, there is no source parameter in pickMultiImage

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser TahaTesser requested a review from cyanglaz as a code owner August 6, 2021 15:40
@google-cla google-cla bot added the cla: yes label Aug 6, 2021
@TahaTesser TahaTesser requested review from ditman and removed request for cyanglaz August 6, 2021 15:43
@TahaTesser TahaTesser changed the title [image_picker] Fix README xxample [image_picker] Fix README example Aug 6, 2021
@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 6, 2021
@fluttergithubbot fluttergithubbot merged commit 083b45e into flutter:master Aug 6, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2021
@engine-flutter-autoroll
083b45e [image_picker] Fix README example (flutter/plugins#4220)
50f883e
@TahaTesser TahaTesser deleted the fix_image_picker_readme branch August 6, 2021 17:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2021
@engine-flutter-autoroll
083b45e [image_picker] Fix README example (flutter/plugins#4220)
9145db6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
@engine-flutter-autoroll
083b45e [image_picker] Fix README example (flutter/plugins#4220)
118e463
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@TahaTesser @fotiDim
[image_picker] Fix README example (flutter#4220)
a8fe784
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@TahaTesser @amantoux
[image_picker] Fix README example (flutter#4220)
7481865
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ditman ditman ditman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: image_picker waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error with image_picker: No named parameter with the name 'source'

3 participants

@TahaTesser @ditman @fluttergithubbot