Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[package_info] Bump SDK version of example app#4494

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
camsim99:bump_pi_sdk
Nov 10, 2021
Merged

[package_info] Bump SDK version of example app#4494
fluttergithubbot merged 2 commits intoflutter:masterfrom
camsim99:bump_pi_sdk

Conversation

@camsim99
Copy link
Copy Markdown
Contributor

@camsim99 camsim99 commented Nov 9, 2021 •
edited
Loading

Bumps package_info example app compileSdkVersion to 30 to match highest compileSdkVersion of dependencies.

@google-cla google-cla bot added the cla: yes label Nov 9, 2021
@camsim99 camsim99 changed the title Bump SDK version of package_info example app [package_info] Bump SDK version of example app Nov 9, 2021
@camsim99 camsim99 marked this pull request as ready for review November 9, 2021 23:23
@flutter-dashboard
Copy link
Copy Markdown

flutter-dashboard bot commented Nov 9, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@camsim99 camsim99 requested a review from blasten November 9, 2021 23:23
blasten
blasten approved these changes Nov 9, 2021
View reviewed changes
Copy link
Copy Markdown

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would still need a sentence in https://github.com/flutter/plugins/blob/1f1e97d178bb90676287bd9a398273bc19fcbe1c/packages/package_info/CHANGELOG.md#next

@blasten blasten added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Nov 10, 2021
@stuartmorgan-g
Copy link
Copy Markdown
Contributor

stuartmorgan-g commented Nov 10, 2021

Don't we need to change everything to 31 anyway before the engine change that was temporarily reverted re-lands?

@fluttergithubbot fluttergithubbot merged commit 112fe4e into flutter:master Nov 10, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
112fe4e [package_info] Bump SDK version of example app (flutter/plugi…
66f2dea 
…ns#4494)
@blasten
Copy link
Copy Markdown

blasten commented Nov 11, 2021

@stuartmorgan Camille is working on this in #4502

amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@camsim99 @amantoux
[package_info] Bump SDK version of example app (flutter#4494)
48833c2
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@camsim99 @KyleFin
[package_info] Bump SDK version of example app (flutter#4494)
edb95c9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes needs tests p: package_info platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camsim99 @stuartmorgan-g @blasten @fluttergithubbot