This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Add setCookie to CookieManager and support initial cookies in creation params.#4561
Merged
stuartmorgan-g merged 41 commits intoflutter:masterfrom Dec 7, 2021
Conversation
…ter/set_cookies_ios
…ter/set_cookies_android
…ter/set_cookies_ios
…ter/set_cookies_android
…er/set_cookies_app
…ter/set_cookies_android
…ter/set_cookies_ios
…ter/set_cookies_ios
…ter/set_cookies_android
…er/set_cookies_app
…er/set_cookies_app
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Drive-by comment nit.
| /// Clears all cookies for all [WebView] instances. | ||
| /// | ||
| /// This is a no op on iOS version smaller than 9. | ||
| /// This is a no op on iOS versions below 9. |
Contributor
There was a problem hiding this comment.
We don't support versions below 9 any more, so you can just remove this.
Contributor
|
Dependencies are published; this is ready to be finalized. |
stuartmorgan-g
suggested changes
Dec 7, 2021
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Just minor things; looks good overall.
Contributor
|
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2021
…initial cookies in creation params. (flutter/plugins#4561)
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…cookies in creation params. (flutter#4561) This PR adds a function for setting cookies to the CookieManager, as well support for setting initial cookies through the `CreationParams` object. Fixes flutter/flutter#27597
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…cookies in creation params. (flutter#4561) This PR adds a function for setting cookies to the CookieManager, as well support for setting initial cookies through the `CreationParams` object. Fixes flutter/flutter#27597
|
@BeMacized |
Contributor
|
This PR was landed last year; it can't be changed. If you have an issue to report, please use the issue tracker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a function for setting cookies to the CookieManager, as well support for setting initial cookies through the
CreationParamsobject.As this PR depends on, and contains the changes of, updates made to the platform interface in #4555, as well as the platform specific implementations in #4556 and #4557, this PR will remain in draft mode until those changes have been merged and published.Fixes flutter/flutter#27597
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.