This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Default Android to hybrid composition#4576
Merged
stuartmorgan-g merged 5 commits intoflutter:masterfrom Dec 8, 2021
Merged
[webview_flutter] Default Android to hybrid composition#4576stuartmorgan-g merged 5 commits intoflutter:masterfrom
stuartmorgan-g merged 5 commits intoflutter:masterfrom
Conversation
Switches the default implemention on Android from virtual display to hybrid composition. This is a breaking change. Part of flutter/flutter#93335
Contributor
Author
|
I've marked this as a Draft only so that we don't accidentally land it before the other things we want in 3.0 have landed; it's ready for review. |
stuartmorgan-g
commented
Dec 4, 2021
| final String? currentUrl = await controller.currentUrl(); | ||
| expect(currentUrl, primaryUrl); | ||
| }); | ||
| }, skip: !Platform.isAndroid || _skipDueToIssue86757); |
Contributor
Author
There was a problem hiding this comment.
Unfortunately this, like pretty much all of our other Android integration tests, currently fails :/
blasten
reviewed
Dec 7, 2021
| ## NEXT | ||
| ## 3.0.0 | ||
|
|
||
| * **BREAKING CHANGE**: On Android, hybrid composition (SurfaceAndroidWebView) |
There was a problem hiding this comment.
I need to think about this one, but at a high level, I don't see why changing the backend should be considered a breaking change.
Contributor
Author
There was a problem hiding this comment.
The default behavior is fundamentally changing; it's safer to do it as part of a breaking change.
(Strictly speaking though, no, this doesn't have to be a breaking change.)
blasten
approved these changes
Dec 7, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
Switches the default implemention on Android from virtual display to hybrid composition. This is a breaking change. Part of flutter/flutter#93335
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Switches the default implemention on Android from virtual display to hybrid composition. This is a breaking change. Part of flutter/flutter#93335
|
Nothing major, but while this was updated: This comment wasn't updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the default implemention on Android from virtual display to
hybrid composition. This is a breaking change.
Part of flutter/flutter#93335
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).