Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Adds additional explanation on the importance of completing a purchase#5017

Merged
fluttergithubbot merged 3 commits intoflutter:mainfrom
Baseflow:iap_complete_purchase_doc
Mar 15, 2022
Merged

[in_app_purchase] Adds additional explanation on the importance of completing a purchase#5017
fluttergithubbot merged 3 commits intoflutter:mainfrom
Baseflow:iap_complete_purchase_doc

Conversation

@mvanbeusekom
Copy link
Copy Markdown
Contributor

Improves the documentation on completing purchases by explaining why it is necessary. This as a request from Zoey came in regarding feedback that it's not clear to developers why completing a purchase is important.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Copy Markdown
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

Comment thread packages/in_app_purchase/in_app_purchase/README.md Outdated
Comment thread packages/in_app_purchase/in_app_purchase/README.md Outdated
Comment thread packages/in_app_purchase/in_app_purchase/README.md Outdated
Comment thread packages/in_app_purchase/in_app_purchase/README.md Outdated
Comment thread packages/in_app_purchase/in_app_purchase/README.md Outdated
Comment thread packages/in_app_purchase/in_app_purchase/README.md Outdated
@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 15, 2022
@fluttergithubbot fluttergithubbot merged commit 6f6cd78 into flutter:main Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 16, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p: in_app_purchase waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants