[image_picker] Federate mobile implementations#5100
[image_picker] Federate mobile implementations#5100fluttergithubbot merged 13 commits intoflutter:mainfrom
Conversation
| @@ -0,0 +1,67 @@ | |||
| def localProperties = new Properties() | |||
There was a problem hiding this comment.
This seems copy and pasted across examples, can we share this easily?
There was a problem hiding this comment.
I don't think there's any reasonable way for us to share native app boilerplate across examples. Especially since over time the dependencies (at the end) could reasonably diverge.
And while this is a duplicate in practice, it's also almost identical to what flutter create would have made for us if we'd made the new example from scratch instead.
|
|
||
| @DartIntegrationTest | ||
| @RunWith(FlutterTestRunner.class) | ||
| public class FlutterActivityTest { |
There was a problem hiding this comment.
Do we need this? It doesn't seem to be doing anything interesting. Is it boilerplate to help future tests? Maybe we could add an example assertion?
There was a problem hiding this comment.
It's boilerplate to run the Dart integration tests in the native harness. The @RunWith(FlutterTestRunner.class) is what does the real work here.
| # When depending on this package from a real application you should use: | ||
| # image_picker_ios: ^x.y.z |
There was a problem hiding this comment.
This stock comment doesn't seem correct, they should depend on image_picker no?
There was a problem hiding this comment.
If someone is explicitly depending on the image_picker_ios package, as the example is doing, they should do it like this.
That's not usually what people should do, but nothing in the implementation examples is what people should usually do with a federated plugin. Usually people just use the app-facing package, and would look at the app-facing package's example.
(The implementation package examples are almost entirely for development and test-running purposes. At some point we should maybe batch-update the README boilerplate we use in them to make that more explicit.)
Co-authored-by: gaaclarke <[email protected]>
Co-authored-by: gaaclarke <[email protected]>
|
This pull request is not suitable for automatic merging in its current state.
|
Temporarily marks
image_pickeras unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form.Part of flutter/flutter#68498
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).