This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Make sure unsupported userInfo doesn't crash App#5111
Merged
fluttergithubbot merged 2 commits intoflutter:mainfrom Apr 4, 2022
Merged
[in_app_purchase] Make sure unsupported userInfo doesn't crash App#5111fluttergithubbot merged 2 commits intoflutter:mainfrom
fluttergithubbot merged 2 commits intoflutter:mainfrom
Conversation
stuartmorgan-g
suggested changes
Mar 28, 2022
| } | ||
| } | ||
| userInfo[key] = errors; | ||
| } else { |
Contributor
There was a problem hiding this comment.
You'll need to handle strings as well; that's what broke the existing test.
Contributor
Author
There was a problem hiding this comment.
Fixed, I also included a check on NSNumber just in case (including matching unit test).
| } else if ([value isKindOfClass:[NSArray class]]) { | ||
| NSMutableArray *errors = [[NSMutableArray alloc] init]; | ||
| for (id error in value) { | ||
| if ([error isKindOfClass:[NSError class]]) { |
Contributor
There was a problem hiding this comment.
Rather than assume that an array must contain errors, we should extract the general conversion code (i.e., this if/else if/... sequency) to a helper and recursively call that helper on the elements of the array.
Contributor
Author
There was a problem hiding this comment.
Fixed, a lot more robust indeed.
e011808 to
e31527b
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from iOS 15.4 the Store Kit framework sends back underlying errors as part of the
[NSError userInfo]field. This results in a crash because the[FIAObjectTranslator getMapFromNSError]method doesn't know how to handle this.This PR updates the
[FIAObjectTranslator getMapFromNSError]method to add support for underlying errors and also catches future unsupported type in a way that doesn't immediately crash the consuming app and instead returns an error string that can be handled on the client side.Resolves flutter/flutter#100458
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.