This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[various] Replaces manual hashing with Object.hash#5314
Merged
fluttergithubbot merged 6 commits intoflutter:mainfrom Apr 21, 2022
Merged
[various] Replaces manual hashing with Object.hash#5314fluttergithubbot merged 6 commits intoflutter:mainfrom
fluttergithubbot merged 6 commits intoflutter:mainfrom
Conversation
Updates `hashValue` implementations that were using manual XOR-based hashing to use Object.hash. This brings them into alignment with the majority of implementations in the repository (which were recently updated from Flutter's `hashValues` to `Object.hash`)
Contributor
Author
|
@hellohuanlin As promised :) |
hellohuanlin
approved these changes
Apr 20, 2022
Contributor
hellohuanlin
left a comment
There was a problem hiding this comment.
beautiful. thx for cleaning this up
blasten
approved these changes
Apr 20, 2022
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
hashValueimplementations that were using manual XOR-basedhashing to use Object.hash. This brings them into alignment with the
majority of implementations in the repository (which were recently
updated from Flutter's
hashValuestoObject.hash)Also does some opportunistic cleanup of cruft references
to
pedanticindev_dependenciesthat I noticed whileupdating the pubspecs.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).