/cc @johnpryan

Thanks, this looks good to me, I'll need to check the version of the Flutter SDK to use before we can put this up on https://flutter.github.io/samples/

I don't think there would be an upgrade of the Flutter SDK needed for the video_player_web plugin. But I guess I should add video_player_platform_interface to the pubspec manually or by running flutter update-packages --force-upgrade right?

I don't think video_player_platform_interface needs to be explicitly added to the pubspec. There's just a question around which version of the Flutter SDK will work with this package.

About any recent Flutter SDK version should work with that package. It's not using anything new as far as I know. Maybe @hterkelsen can confirm?

@johnpryan has this been published to https://flutter.github.io/samples/#/ already?

Yeah, although I wasn't sure if this was meant to fix the GIFs or the videos. The videos don't seem to be working.

It was supposed to fix the videos but I should have tested this locally. There is code in video_demo.dart which will not work on the web. Is it ok to fix it in this repo or do I need to fix this in https://github.com/flutter/flutter/tree/master/examples/flutter_gallery?

I would recommend fixing it in the flutter repo, this version of the gallery is pulled from there.

If this is due to videos loaded from assets, I filed an issue to support that here: flutter/flutter#46621

I will send a PR out shortly.

Thanks Harry! This is one of the issues. Others include missing connectivity plugin and usage of dart:io to check if it is running in an iOS simulator. I will search for a solution and open a PR in flutter/flutter.

I have opened a PR in flutter/flutter that should fix video playback on web. It's linked to @cbenhagen 's ticket above:

• Change video_demo slightly so it works on web. flutter#46719