Skip to content

[Gallery] Add platform setting for macOS, Linux, Windows#192

Closed
guidezpl wants to merge 1 commit intomasterfrom
macos-platform
Closed

[Gallery] Add platform setting for macOS, Linux, Windows#192
guidezpl wants to merge 1 commit intomasterfrom
macos-platform

Conversation

@guidezpl
Copy link
Copy Markdown
Member

@guidezpl guidezpl commented Dec 18, 2019

  • Adds a platform setting for macOS.
  • Removed unnecessary TargetPlatformOverrides, to match defaults in flutter/flutter
  • Removed the unnecessary translations for the terms 'Android' and 'iOS'.

Closes material-components/material-components-flutter-gallery/issues/380

TODO: add Linux, Windows platform settings

We'll wait until the change makes it to the Flutter stable channel to merge.

Simulator Screen Shot - iPhone 11 Pro - 2019-11-28 at 19 05 28

@redbrogdon
Copy link
Copy Markdown
Contributor

This PR has been open for a while. Is it still in progress, or should it be closed?

@guidezpl
Copy link
Copy Markdown
Member Author

It's ready, just waiting on flutter/flutter#43457 to make it to the stable channel

@guidezpl guidezpl changed the title Add platform setting for macOS [Gallery] Add platform setting for macOS Jan 23, 2020
@guidezpl guidezpl changed the title [Gallery] Add platform setting for macOS [Gallery] Add platform setting for macOS, Linux, Windows Mar 4, 2020
@guidezpl
Copy link
Copy Markdown
Member Author

guidezpl commented Mar 4, 2020

All platforms now supported, so I'll update this PR and wait for flutter/flutter@1ba4f1f to make it to stable

@guidezpl
Copy link
Copy Markdown
Member Author

guidezpl commented Mar 9, 2020

No longer needed since the gallery has moved to https://github.com/flutter/gallery

@guidezpl guidezpl closed this Mar 9, 2020
@guidezpl guidezpl deleted the macos-platform branch March 9, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle macOS, linux, windows TargetPlatform

2 participants