Skip to content

[video_player] Update README.md for video_player#978

Merged
JSUYA merged 3 commits intoflutter-tizen:masterfrom
gin7773:update_patching/video_player
Apr 3, 2026
Merged

[video_player] Update README.md for video_player#978
JSUYA merged 3 commits intoflutter-tizen:masterfrom
gin7773:update_patching/video_player

Conversation

@gin7773
Copy link
Copy Markdown
Contributor

@gin7773 gin7773 commented Apr 3, 2026

Main changes:

  • Update limitations section of the README.md

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md for the video_player package to include a list of unsupported VideoPlayerPlatform methods. A review comment points out inaccuracies in the documented method names, specifically suggesting that selectAudioTrack() be changed to setAudioTrack() and noting that isAudioTrackSupportAvailable() is not part of the interface.

@gin7773 gin7773 requested review from JSUYA and xiaowei-guan April 3, 2026 03:11
@JSUYA
Copy link
Copy Markdown
Member

JSUYA commented Apr 3, 2026

Please update plugin version. The updated README should be published.

@gin7773
Copy link
Copy Markdown
Contributor Author

gin7773 commented Apr 3, 2026

Please update plugin version. The updated README should be published.

Updated.

@JSUYA JSUYA merged commit 2885a5b into flutter-tizen:master Apr 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants