Fix parsing of gradle dependency tree#500
Merged
zlav merged 3 commits intofossas:masterfrom Aug 9, 2019
pascal-hofmann:master
Merged
Fix parsing of gradle dependency tree#500zlav merged 3 commits intofossas:masterfrom pascal-hofmann:master
zlav merged 3 commits intofossas:masterfrom
pascal-hofmann:master
Conversation
|
|
golangcibot
reviewed
Aug 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
======================================
Coverage 52.4% 52.4%
======================================
Files 103 103
Lines 5761 5761
======================================
Hits 3019 3019
Misses 2461 2461
Partials 281 281
Continue to review full report at Codecov.
|
Contributor
Author
|
cla-assistant.io is down right now. Will sign the CLA once it is back up… Edit: This is done (signed) now. |
dchenk
suggested changes
Aug 5, 2019
dchenk
left a comment
There was a problem hiding this comment.
Thanks for the proposed fix. One comment about the regex.
Co-Authored-By: Dmitriy <[email protected]>
Contributor
Author
|
Hey, do I still need to do something to get this merged? |
|
Apologies for the delayed response. I was going to investigate why the CI tests failed. I'd like to get this merged soon. |
dchenk
reviewed
Aug 7, 2019
Co-Authored-By: Dmitriy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one of my projects I have a gradle dependency tree that looks like this:
This breaks the gradle analyzer. It bails out with the error message
This PR improves the regex used to match gradle dependencies based on the possible output generated by gradle (see https://github.com/gradle/gradle/blob/e975872ae2cf1d521b73f1107cae772ca09c63cd/subprojects/core/src/main/java/org/gradle/internal/graph/GraphRenderer.java)