Skip to content

SBT Launcher update 1.0.0#76

Merged
eed3si9n merged 16 commits intomasterfrom
unknown repository
Apr 9, 2016
Merged

SBT Launcher update 1.0.0#76
eed3si9n merged 16 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 28, 2015

  • Use wget instead of curl (avoiding certificate errors)
  • Let the user choose directories

Tested on Ubuntu 15.04 & 14.04.3

@eed3si9n
Copy link
Copy Markdown
Member

Partly duplicate of #75

eed3si9n added 2 commits July 28, 2015 15:37
Updated sbt launch repository (earlier Artifactory-based repo no longer works)
Update command to start jar to current version
@mismatch
Copy link
Copy Markdown

sbt 0.13.9 has been already released. It would be better to update to latest version.

@ghost ghost changed the title SBT Launch update 0.13.8 SBT Launch update 0.13.9 Aug 15, 2015
@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 15, 2015

Done. 👌

@eed3si9n
Copy link
Copy Markdown
Member

sbt project split up the launcher project into sbt/launcher, so maybe it's better to use launcher 1.0.0 JAR. This is binary compatible with current sbt 0.13 series, and we will keep binary compatibility for the next major version sbt 1.0 as well:
https://oss.sonatype.org/content/repositories/public/org/scala-sbt/launcher/1.0.0/launcher-1.0.0.jar

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 21, 2015

Yeah, sounds great!

@eed3si9n
Copy link
Copy Markdown
Member

Could you rebase against the master?

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 21, 2015

I don't know if I did it right. Sorry if I did a mess 😞

@eed3si9n
Copy link
Copy Markdown
Member

The part about the launcher JAR looks ok, but I'd like to hear what @n8han thinks about letting the user choose directories in setup.sh.

@ghost ghost changed the title SBT Launch update 0.13.9 SBT Launcher update 1.0.0 Aug 21, 2015
@eed3si9n eed3si9n merged commit ad20308 into foundweekends:master Apr 9, 2016
@eed3si9n
Copy link
Copy Markdown
Member

Asking the user where to put things is actually misleading because the directory the user entered is not honored by the conscript Scala application. I'm going to change this slightly and allow the user specify environment variables, and ask the user if the default value is ok: Y/n

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 10, 2016

Sounds good, @eed3si9n, the [Y/n] prompt is pretty common 👍

eed3si9n added a commit that referenced this pull request Nov 5, 2016
Modify docs to use wget, not curl, after change in #76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants