Properly handle checksums of '0' in usps mod10.#30
Merged
franckverrot merged 1 commit intofranckverrot:masterfrom Nov 17, 2011
Merged
Properly handle checksums of '0' in usps mod10.#30franckverrot merged 1 commit intofranckverrot:masterfrom
franckverrot merged 1 commit intofranckverrot:masterfrom
Conversation
Current implementation returns 10, which does not equal 0.
franckverrot
added a commit
that referenced
this pull request
Nov 17, 2011
Properly handle checksums of '0' in usps mod10.
Owner
|
thanks! |
franckverrot
added a commit
that referenced
this pull request
Nov 26, 2011
* TrackingNumberValidator: fix in the USPS computation. * Tests: removed turn because it was failing everywhere but on 1.9.x. * PostalCodeValidator: Added Portuguese postal-code format. b1901cd cesario Simplify the test and make sure Ruby 1.9x stop complaining c1e0cb6 robzuber Properly handle checksums of '0' in usps mod10. 4479260 cesario Merge pull request #30 from utahstreetlabs/mod10-equals-zero 158911b MMSequeira Added Portuguese postal-code format.1 day ago 9c0ea20 MMSequeira Added a new option country_method allowing the country to be obtained... 144a366 MMSequeira Corrected example of use of the postal code validator. 7038a37 cesario Merge pull request #31 from MMSequeira/master 1e9473b cesario Remove turn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation returns 10, which does not equal 0.