Open
Conversation
pedram-aliniaye-asli
suggested changes
Sep 15, 2024
There was a problem hiding this comment.
You did a great job here!
Just a few quick notes:
- Please add comments to your code to make it clearer for other people and explain what is happening in your code.
- Your assignment should be in a branch called
assignment-2, not in theassignment.
Please go ahead and do the modifications and then let me know. Thanks!
Owner
Author
|
I have added comments to the code and submitted it through a new branch assignment 2. I have opened a pull request for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completed assignment 2 for python
What did you learn from the changes you have made?
I learnt how to read foes in python, how to write python functions for working on files using numpy
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Was thinking of using pandas for the analysis
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The challenges were that of locating and properly referencing the folders.
How were these changes tested?
They were tested by calling the functions
A reference to a related issue in your repository (if applicable)
None
Checklist