Merged
Conversation
simon04
reviewed
Dec 4, 2020
Contributor
simon04
left a comment
There was a problem hiding this comment.
Can we link to out Java docs, i.e., replace the link https://docs.oracle.com/javase/8/docs/api/java/io/File.html with https://devdocs.io/openjdk~8/java/io/file?
Contributor
Author
|
There's a long history/discussion with internal linking between documentation sets: #234 If we do decide to do something, I think this would be a good test case. |
Contributor
Author
|
I just noticed every package link on the homepage is broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you’re adding a new scraper, please ensure that you have:
public/icons/your_scraper_name/directory:16.png: a 16×16 pixel icon for the doc[email protected]: a 32×32 pixel icon for the docSOURCE: A text file containing the URL to the page the image can be found on or the URL of the original image itself