Skip to content

Update Twig to 3.1.1 and update previous versions#1403

Merged
simon04 merged 3 commits intofreeCodeCamp:masterfrom
MasterEnoc:twig
Dec 9, 2020
Merged

Update Twig to 3.1.1 and update previous versions#1403
simon04 merged 3 commits intofreeCodeCamp:masterfrom
MasterEnoc:twig

Conversation

@MasterEnoc
Copy link
Copy Markdown
Contributor

@MasterEnoc MasterEnoc commented Dec 5, 2020

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

@MasterEnoc MasterEnoc requested a review from a team as a code owner December 5, 2020 01:08
@scherepn
Copy link
Copy Markdown
Contributor

scherepn commented Dec 6, 2020

Good catch on updating the logo, but your logo source was missing an alpha channel.

Here's the same icon, but squared off, and with transparency:
twig-logo

URL is https://twig.symfony.com/images/logo.png

@scherepn
Copy link
Copy Markdown
Contributor

scherepn commented Dec 6, 2020

https://github.com/scherepn/devdocs/tree/twig

@MasterEnoc
Copy link
Copy Markdown
Contributor Author

MasterEnoc commented Dec 7, 2020

Thanks @scherepn. Now the logo is the correct one

@simon04
Copy link
Copy Markdown
Contributor

simon04 commented Dec 7, 2020

The code blocks contain line numbers and look strange:

Screenshot 2020-12-07 at 11 47 38

@MasterEnoc
Copy link
Copy Markdown
Contributor Author

MasterEnoc commented Dec 8, 2020

Fixed, proceed to review

simon04
simon04 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simon04 simon04 merged commit c0dbaaf into freeCodeCamp:master Dec 9, 2020
@MasterEnoc MasterEnoc deleted the twig branch May 1, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon04 simon04 simon04 approved these changes

Assignees

No one assigned

Labels

docs/update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MasterEnoc @scherepn @simon04