Skip to content

Update Nim to 1.4.2#1407

Merged
simon04 merged 1 commit intofreeCodeCamp:masterfrom
MasterEnoc:nim
Dec 7, 2020
Merged

Update Nim to 1.4.2#1407
simon04 merged 1 commit intofreeCodeCamp:masterfrom
MasterEnoc:nim

Conversation

@MasterEnoc
Copy link
Copy Markdown
Contributor

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

Caveats

There are some entries with duplicate name. This happen because some procedures, macros and templates share the same name, look at the following image:

image

The module 'astalgo' has five 'debug' entries, where three are procedures with different arguments and two are templates. Any idea or suggestion to improve this would be helpful.

@MasterEnoc MasterEnoc requested a review from a team as a code owner December 7, 2020 01:56
Copy link
Copy Markdown
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@simon04 simon04 merged commit b924eb1 into freeCodeCamp:master Dec 7, 2020
@scherepn scherepn mentioned this pull request Dec 10, 2020
5 tasks
@MasterEnoc MasterEnoc deleted the nim branch May 1, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants