Skip to content

Update Bash to 5.1#1414

Merged
simon04 merged 2 commits intofreeCodeCamp:masterfrom
MasterEnoc:bash
Dec 9, 2020
Merged

Update Bash to 5.1#1414
simon04 merged 2 commits intofreeCodeCamp:masterfrom
MasterEnoc:bash

Conversation

@MasterEnoc
Copy link
Copy Markdown
Contributor

@MasterEnoc MasterEnoc commented Dec 8, 2020

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

@MasterEnoc MasterEnoc requested a review from a team as a code owner December 8, 2020 19:21
scherepn
scherepn reviewed Dec 8, 2020
View reviewed changes
lib/docs/filters/bash/entries.rb Outdated
# remove 'E.' notation for appendixes
if name.match?(/[[:upper:]]\./)
# remove 'E.'
name = name.sub(/[[:upper:]]\./, '')
Copy link
Copy Markdown
Contributor

@scherepn scherepn Dec 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the name.sub! function to do an in-place operation on a string instead.

@MasterEnoc
Copy link
Copy Markdown
Contributor Author

MasterEnoc commented Dec 9, 2020

Code improved.
Thanks for your suggestions @scherepn.

simon04
simon04 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simon04 simon04 merged commit cfa5237 into freeCodeCamp:master Dec 9, 2020
@MasterEnoc MasterEnoc deleted the bash branch May 1, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon04 simon04 simon04 approved these changes

+1 more reviewer

@scherepn scherepn scherepn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs/update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MasterEnoc @scherepn @simon04