feat: deploy via GitHub action#1509
Merged
ojeytonwilliams merged 2 commits intofreeCodeCamp:masterfrom Mar 29, 2021
Merged
Conversation
simon04
approved these changes
Mar 29, 2021
Contributor
simon04
left a comment
There was a problem hiding this comment.
Looks good. Let's give it a try! 🚀
|
|
||
| script: | ||
| - if [ "$TRAVIS_EVENT_TYPE" != "cron" ]; then bundle exec rake; fi | ||
| - if [ "$TRAVIS_EVENT_TYPE" = "cron" ]; then bundle exec thor updates:check --github-token $GH_TOKEN --upload; fi |
Contributor
There was a problem hiding this comment.
The thor updates:check runs once a month and can probably be added later once the deployment is working again.
Contributor
Author
There was a problem hiding this comment.
Agreed. I'll add a second action to trigger those on the current schedule.
Co-authored-by: Simon Legner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@simon04 could you give this a quick sanity check? It's basically what @jmerle suggested, with the
heroku-deployaction at the end.If you're happy please merge, then we can see if deployments start happening again.
Fixes #1508.