Skip to content

fix: set branch to master in deploy action#1510

Merged
ojeytonwilliams merged 1 commit intofreeCodeCamp:masterfrom
ojeytonwilliams:feat/migrate-to-actions
Mar 29, 2021
Merged

fix: set branch to master in deploy action#1510
ojeytonwilliams merged 1 commit intofreeCodeCamp:masterfrom
ojeytonwilliams:feat/migrate-to-actions

Conversation

@ojeytonwilliams
Copy link
Copy Markdown
Contributor

$default-branch did not seem to catch merges to master, so this PR names the branch that should trigger the action.

@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner March 29, 2021 12:50
@ojeytonwilliams ojeytonwilliams merged commit 3a39aa7 into freeCodeCamp:master Mar 29, 2021
@ojeytonwilliams ojeytonwilliams deleted the feat/migrate-to-actions branch March 29, 2021 12:51
push:
branches: [ $default-branch ]
branches:
- master
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojeytonwilliams This should be changed to main.

Copy link
Copy Markdown
Contributor Author

@ojeytonwilliams ojeytonwilliams Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'll do that and update the action. Edit: that's why I wanted to use $default-branch, but sadly it wasn't playing ball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants