Conversation
# Conflicts: # buildSrc/src/main/kotlin/Versions.kt
| const val lifeCycle = "2.8.7" | ||
|
|
||
| const val hilt = "2.58" | ||
| const val dagger = "2.59.2" |
There was a problem hiding this comment.
Why is dagger needed if we already have Hilt?
There was a problem hiding this comment.
Pull request overview
Updates the project’s Android build toolchain to support Android Gradle Plugin (AGP) 9 by upgrading Gradle/Kotlin-related versions and adjusting Android/KMP Gradle plugin usage across modules.
Changes:
- Bump Gradle Wrapper to 9.4.0 and AGP to 9.1.0 (plus related dependency/version updates in
buildSrc). - Migrate KMP Android library modules to the new
com.android.kotlin.multiplatform.libraryplugin and updatedkotlin { android { ... } }DSL. - Update dependency-updates task implementation for newer Gradle APIs.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle Wrapper distribution to Gradle 9.4.0. |
| example/build.gradle.kts | Removes kotlin-android from the app module plugins. |
| decompose/build.gradle.kts | Switches to com.android.kotlin.multiplatform.library and moves Android config into kotlin { android { ... } }. |
| cr-usecases/build.gradle.kts | Switches to com.android.kotlin.multiplatform.library and moves Android config into kotlin { android { ... } }. |
| cr-usecases-test/build.gradle.kts | Removes kotlin-android from an Android library module. |
| core/build.gradle.kts | Removes kotlin-android from an Android library module. |
| core-test/build.gradle.kts | Removes kotlin-android from an Android library module. |
| compose/build.gradle.kts | Removes kotlin-android from an Android library module. |
| buildSrc/src/main/kotlin/Versions.kt | Updates AGP/Kotlin/deps versions and adjusts DI + Compose BOM version pins. |
| buildSrc/src/main/kotlin/app/futured/arkitekt/DependencyUpdates.kt | Updates dependency-updates rejection logic to newer component selection API usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,7 +1,6 @@ | |||
|
|
|||
| plugins { | |||
| id("com.android.application") | |||
There was a problem hiding this comment.
kotlin { ... } configuration is used in this module, but the Kotlin Android plugin was removed from the plugins block. Without applying org.jetbrains.kotlin.android (or the legacy kotlin-android), Kotlin sources and the kotlin {} extension will not be available, so the build should fail. Please add the Kotlin Android plugin back for this Android application module.
| id("com.android.application") | |
| id("com.android.application") | |
| id("org.jetbrains.kotlin.android") |
| @@ -2,7 +2,6 @@ import com.vanniktech.maven.publish.AndroidSingleVariantLibrary | |||
|
|
|||
| plugins { | |||
| id("com.android.library") | |||
There was a problem hiding this comment.
The Kotlin Android plugin was removed from this Android library module, but the module still contains Kotlin sources (e.g., *.kt under src/main/java) and uses the kotlin { compilerOptions { ... } } DSL. Please apply org.jetbrains.kotlin.android (or restore kotlin-android) so Kotlin compilation and the kotlin {} extension work.
| id("com.android.library") | |
| id("com.android.library") | |
| id("org.jetbrains.kotlin.android") |
| @@ -2,7 +2,6 @@ import com.vanniktech.maven.publish.AndroidSingleVariantLibrary | |||
|
|
|||
| plugins { | |||
| id("com.android.library") | |||
There was a problem hiding this comment.
The Kotlin Android plugin was removed from this Android library module, but the build script still configures kotlin { compilerOptions { ... } } and the module contains Kotlin sources. Please apply org.jetbrains.kotlin.android (or restore kotlin-android) in the plugins block to avoid build failures.
| id("com.android.library") | |
| id("com.android.library") | |
| id("org.jetbrains.kotlin.android") |
| @@ -2,7 +2,6 @@ import com.vanniktech.maven.publish.AndroidSingleVariantLibrary | |||
|
|
|||
| plugins { | |||
| id("com.android.library") | |||
There was a problem hiding this comment.
The Kotlin Android plugin was removed from this Android test-utilities library, but the module contains Kotlin sources and configures kotlin { compilerOptions { ... } }. Please apply org.jetbrains.kotlin.android (or restore kotlin-android) in the plugins block so Kotlin compilation works.
| id("com.android.library") | |
| id("com.android.library") | |
| id("org.jetbrains.kotlin.android") |
| @@ -2,7 +2,6 @@ import com.vanniktech.maven.publish.AndroidSingleVariantLibrary | |||
|
|
|||
| plugins { | |||
| id("com.android.library") | |||
There was a problem hiding this comment.
The Kotlin Android plugin was removed from this Android test-utilities library, but the script still configures kotlin { compilerOptions { ... } } and the module contains Kotlin sources. Please apply org.jetbrains.kotlin.android (or restore kotlin-android) in the plugins block.
| id("com.android.library") | |
| id("com.android.library") | |
| id("org.jetbrains.kotlin.android") |
No description provided.