Fix basedpyright type errors blocking CI deploys#221
Merged
Conversation
Resolve 47 basedpyright errors that were blocking CI deploys. Add pyrightconfig.json with explicit include paths to scope checks to src/ and tests/. Update integration tests to use the unified input API (data= instead of removed input_csv=). Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Patch get_access_token in both tools.py and tool_helpers.py so ownership checks pass in HTTP-mode integration tests - Update extract_poll_token to read top-level poll_token field instead of parsing it from progress_url query string - Add missing asyncio.sleep(2) to poll_via_tool (was hammering API) - Increase default max_polls from 30 to 60 for real API latency Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/andtests/that were blocking CIchecksjob (and therefore staging/production deploys)pyrightconfig.jsonwith explicitinclude: ["src", "tests"]to scope type checking and exclude untrackedscripts/test_http_real.pyintegration tests to use the unified input API (data=instead of removedinput_csv=)poll_tokennullability inresult_store.py(poll_token or "")Changes by category
Type annotations — Add missing generic args (
dict[str, Any],list[Any],tuple[Any, ...]) andAnyimports across 9 test files and 2 src files.Runtime fixes:
utils.py: Wrapsockaddr[0]instr()to handlestr | intfromsocket.getaddrinforesult_store.py:poll_token or ""to preventNonereaching astrparameteruploads.py:dict→dict[str, Any]in_validate_uploadreturn typeTest fixes:
test_http_real.py:input_csv=→data=(unified input API from PR Unified input API: artifact_id + data replaces input_csv #207)test_auth.py:AnyUrl()wrapper forredirect_uritest_http_integration.py:pd.io.common.StringIO→io.StringIOTest plan
basedpyright --project .→ 0 errorspytest tests/ -x -q→ 347 passed, 28 skippedruff check src/ tests/→ all checks passed🤖 Generated with Claude Code