Rendering "src" attribute for routes using their devices.#71
Open
ams-tschoening wants to merge 1 commit intofwbuilder:masterfrom
Open
Rendering "src" attribute for routes using their devices.#71ams-tschoening wants to merge 1 commit intofwbuilder:masterfrom
ams-tschoening wants to merge 1 commit intofwbuilder:masterfrom
Conversation
|
I'm pretty sure those 2 versions aren't really a reference to the running kernel, rather, they specify the split between older/newer netfilter stuff (basically which way the rules are written for the kernel interface). I think it's basically the cutoff for whether to use the newer netlink interface (which only exists in 3.1.7+). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the following:
to:
Consider this a PoC for #70 again.
While the GUI allows devices without an address, rendering scripts for such setups fails with the following error. So it seems unnecessary to check if an address is available or not and render differently.
Besides that, it's unclear to me how to handle things like different versions of the Linux kernel, because there are two different directories available: