g4code · ppavlovic · Oct 20, 2023 · Oct 20, 2023
diff --git a/.gitignore b/.gitignore
@@ -17,6 +17,7 @@ vendor
 
 tests/unit/coverage/*
 tests/integration/coverage/*
+tests/unit/.phpunit.result.cache
 .vagrant/
 .bash_history
 .cache/motd.legal-displayed

diff --git a/composer.json b/composer.json
@@ -32,30 +32,33 @@
             "G4\\DataMapper\\Test\\Integration\\": "tests/integration"
         }
     },
+    "include-path": [
+        "vendor/g4/zf1-future-zend-db/library/"
+    ],
     "require-dev": {
-        "phpunit/phpunit"           : "5.*",
-        "phpunit/php-code-coverage" : "^3",
+        "phpunit/phpunit"           : "9.6.*",
+        "phpunit/php-code-coverage" : "9.2.*",
         "squizlabs/php_codesniffer" : "3.*",
         "g4/code-coverage"          : "1.*"
     },
     "require": {
-        "php"             : ">=5.6",
+        "php"             : ">=7.3",
         "ext-curl"        : "*",
         "ext-json"        : "*",
         "g4/factory"      : "1.*",
         "g4/profiler"     : ">=1.11.0",
         "g4/value-object" : ">=3.6.0",
-        "zf1/zend-db"     : "1.12.*"
+        "g4/zf1-future-zend-db" : "1.23.*"
     },
     "scripts": {
         "unit-test": [
-            "vendor/bin/phpunit -c tests/unit/phpunit.xml --colors=always --coverage-html tests/unit/coverage"
+            "XDEBUG_MODE=coverage vendor/bin/phpunit -c tests/unit/phpunit.xml --colors=always --coverage-html tests/unit/coverage"
         ],
         "test-coverage": [
-            "./vendor/bin/phpunit --colors=always -c tests/unit/phpunit.xml --coverage-text"
+            "XDEBUG_MODE=coverage ./vendor/bin/phpunit --colors=always -c tests/unit/phpunit.xml --coverage-text"
         ],
         "test-report": [
-            "./vendor/bin/phpunit --colors=always -c tests/unit/phpunit.xml --coverage-clover=tests/unit/coverage/code-coverage.xml"
+            ".XDEBUG_MODE=coverage /vendor/bin/phpunit --colors=always -c tests/unit/phpunit.xml --coverage-clover=tests/unit/coverage/code-coverage.xml"
         ],
         "code-coverage": [
             "./vendor/bin/code-coverage -p 90 -f tests/unit/coverage/code-coverage.xml"

diff --git a/src/Engine/Elasticsearch/ElasticsearchClient.php b/src/Engine/Elasticsearch/ElasticsearchClient.php
@@ -307,7 +307,7 @@ private function throwCurlException($code, $message, $url, $body, $response)
     {
         throw new ClientException(
             sprintf(
-                "Unexpected response code:%s from ES has been returned on submit. More info: %s. Url: %s. Body: %s. Response: %s",
+                "Unexpected response code:%s from ES has been returned on submit. More info: %s. Url: %s. Body: %s. Response: %s", // phpcs:ignore
                 $code,
                 json_encode($message),
                 (string) $url,

diff --git a/src/Engine/Elasticsearch/Operators/ConsistentRandomKey.php b/src/Engine/Elasticsearch/Operators/ConsistentRandomKey.php
@@ -27,4 +27,4 @@ public function format()
             ]
         ];
     }
-}
+}
diff --git a/src/Engine/Elasticsearch/Operators/ExistsOperator.php b/src/Engine/Elasticsearch/Operators/ExistsOperator.php
@@ -20,6 +20,6 @@ public function __construct($name, SingleValue $value)
 
     public function format()
     {
-       return [QueryConnector::EXISTS => ['field' => $this->name]];
+        return [QueryConnector::EXISTS => ['field' => $this->name]];
     }
 }
diff --git a/src/Engine/Elasticsearch/Operators/LikeCIOperator.php b/src/Engine/Elasticsearch/Operators/LikeCIOperator.php
@@ -29,7 +29,9 @@ public function format()
     {
         return [
             QueryConnector::NAME_QUERY_STRING => [
-                QueryConnector::NAME_QUERY_STRING_QUERY => $this->name . ":" . QueryConnector::ROUND_BRACKET_OPEN . QueryConnector::WILDCARD . $this->value . QueryConnector::WILDCARD . QueryConnector::ROUND_BRACKET_CLOSE
+                QueryConnector::NAME_QUERY_STRING_QUERY =>
+                    $this->name . QueryConnector::COLON . QueryConnector::ROUND_BRACKET_OPEN . QueryConnector::WILDCARD
+                    . $this->value . QueryConnector::WILDCARD . QueryConnector::ROUND_BRACKET_CLOSE
             ]
         ];
     }

diff --git a/src/Engine/Elasticsearch/Version7/Operators/ConsistentRandomKey.php b/src/Engine/Elasticsearch/Version7/Operators/ConsistentRandomKey.php
@@ -29,4 +29,4 @@ public function format()
             ]
         ];
     }
-}
+}
diff --git a/src/Engine/Elasticsearch/Version7/Operators/LikeCIOperator.php b/src/Engine/Elasticsearch/Version7/Operators/LikeCIOperator.php
@@ -29,7 +29,8 @@ public function format()
     {
         return [
             QueryConnector::NAME_QUERY_STRING => [
-                QueryConnector::NAME_QUERY_STRING_QUERY => $this->name . ":" . QueryConnector::WILDCARD . strtolower($this->value) . QueryConnector::WILDCARD
+                QueryConnector::NAME_QUERY_STRING_QUERY =>
+                    $this->name . ":" . QueryConnector::WILDCARD . strtolower($this->value) . QueryConnector::WILDCARD
             ]
         ];
     }

diff --git a/src/Engine/Http/HttpPath.php b/src/Engine/Http/HttpPath.php
@@ -20,7 +20,7 @@ class HttpPath implements CollectionNameInterface
      * HttpPath constructor.
      * @param array ...$parts string
      */
-    public function __construct(... $parts)
+    public function __construct(...$parts)
     {
         $path = join(self::SLASH, $parts);
 

diff --git a/tests/unit/src/BuilderTest.php b/tests/unit/src/BuilderTest.php
@@ -1,9 +1,10 @@
 <?php
 
 use G4\DataMapper\Builder;
+use G4\DataMapper\Engine\MySQL\MySQLMapper;
 use G4\DataMapper\Engine\MySQL\MySQLTableName;
 
-class BuilderTest extends PHPUnit_Framework_TestCase
+class BuilderTest extends \PHPUnit\Framework\TestCase
 {
 
     /**
@@ -16,8 +17,7 @@ class BuilderTest extends PHPUnit_Framework_TestCase
      */
     private $params;
 
-
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->params = [
             'host'     => 'localhost',
@@ -29,7 +29,7 @@ protected function setUp()
         $this->builder = Builder::create();
     }
 
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->params = null;
         $this->builder = null;
@@ -54,7 +54,7 @@ public function testBuildMapper()
         $this->builder
             ->collectionName(new MySQLTableName('profiles'))
             ->adapter($this->getMockForMySQLAdapter());
-        $this->builder->buildMapper();
+        $this->assertInstanceOf(MySQLMapper::class, $this->builder->buildMapper());
     }
 
     public function testBuildBulk()
@@ -76,7 +76,7 @@ public function testBuildWithNoAdapter()
 
     public function testBuildWithNoType()
     {
-        $this->builder->adapter($this->getMock('\G4\DataMapper\Common\AdapterInterface'));
+        $this->builder->adapter($this->createMock('\G4\DataMapper\Common\AdapterInterface'));
         $this->expectException('\Exception');
         $this->expectExceptionCode(601);
         $this->expectExceptionMessage('DataSet cannot be emty');
@@ -86,7 +86,7 @@ public function testBuildWithNoType()
     public function testBuildForUnknownEngine()
     {
         $this->builder
-            ->adapter($this->getMock('\G4\DataMapper\Common\AdapterInterface'))
+            ->adapter($this->createMock('\G4\DataMapper\Common\AdapterInterface'))
             ->collectionName(new MySQLTableName('profiles'));
         $this->expectException('\Exception');
         $this->expectExceptionCode(601);
@@ -104,12 +104,10 @@ public function testBuildTransaction()
 
     private function getMockForMySQLAdapter()
     {
-        return $this->getMock(
-            '\G4\DataMapper\Engine\MySQL\MySQLAdapter',
-            null,
-            [
-                $this->getMock('\G4\DataMapper\Engine\MySQL\MySQLClientFactory', null, [$this->params]),
-            ]
-        );
+        return $this->getMockBuilder('\G4\DataMapper\Engine\MySQL\MySQLAdapter')
+            ->setConstructorArgs([
+                $this->createMock('\G4\DataMapper\Engine\MySQL\MySQLClientFactory'),
+            ])
+            ->getMock();
     }
 }
diff --git a/tests/unit/src/Common/BulkTest.php b/tests/unit/src/Common/BulkTest.php
@@ -2,7 +2,7 @@
 
 use G4\DataMapper\Common\Bulk;
 
-class BulkTest extends PHPUnit_Framework_TestCase
+class BulkTest extends \PHPUnit\Framework\TestCase
 {
 
     /**
@@ -21,7 +21,7 @@ class BulkTest extends PHPUnit_Framework_TestCase
     private $tableNameMock;
 
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->adapterMock = $this->getMockBuilder('\G4\DataMapper\Common\AdapterInterface')
             ->disableOriginalConstructor()
@@ -39,7 +39,7 @@ protected function setUp()
         $this->bulk = new Bulk($this->adapterMock, $this->tableNameMock);
     }
 
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->adapterMock      = null;
         $this->tableNameMock    = null;

diff --git a/tests/unit/src/Common/CoordinatesValueTest.php b/tests/unit/src/Common/CoordinatesValueTest.php
@@ -2,20 +2,20 @@
 
 use G4\DataMapper\Common\CoordinatesValue;
 
-class CoordinatesValueTest extends PHPUnit_Framework_TestCase
+class CoordinatesValueTest extends \PHPUnit\Framework\TestCase
 {
 
     /**
      * @var CoordinatesValue
      */
     private $coordinates;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->coordinates = new CoordinatesValue(46.100376, 19.667587, 100);
     }
 
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->coordinates = null;
     }

diff --git a/tests/unit/src/Common/IdentityTest.php b/tests/unit/src/Common/IdentityTest.php
@@ -2,7 +2,7 @@
 
 use G4\DataMapper\Common\Identity;
 
-class IdentityTest extends PHPUnit_Framework_TestCase
+class IdentityTest extends \PHPUnit\Framework\TestCase
 {
 
     /**
@@ -11,12 +11,12 @@ class IdentityTest extends PHPUnit_Framework_TestCase
     private $identity;
 
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->identity = new Identity();
     }
 
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->identity = null;
     }
@@ -27,7 +27,8 @@ public function testEqual()
 
         $this->assertInstanceOf(\G4\DataMapper\Common\Selection\Comparison::class, $this->identity->getComparisons()[0]);
 
-        $this->setExpectedException('\Exception', 'Value can not be array');
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Value can not be array');
         $this->identity->field('name')->equal([1]);
     }
 
@@ -42,15 +43,17 @@ public function testGreaterThan()
     {
         $this->assertInstanceOf(\G4\DataMapper\Common\Identity::class, $this->identity->field('id')->greaterThan(1));
 
-        $this->setExpectedException('\Exception', 'Value can not be array');
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Value can not be array');
         $this->identity->field('name')->greaterThan([1]);
     }
 
     public function testGreaterThanOrEqual()
     {
         $this->assertInstanceOf(\G4\DataMapper\Common\Identity::class, $this->identity->field('id')->greaterThanOrEqual(1));
 
-        $this->setExpectedException('\Exception', 'Value can not be array');
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Value can not be array');
         $this->identity->field('name')->greaterThanOrEqual([1]);
     }
 
@@ -63,23 +66,26 @@ public function testLessThan()
     {
         $this->assertInstanceOf(\G4\DataMapper\Common\Identity::class, $this->identity->field('id')->lessThan(1));
 
-        $this->setExpectedException('\Exception', 'Value can not be array');
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Value can not be array');
         $this->identity->field('name')->lessThan([1]);
     }
 
     public function testLessThanOrEqual()
     {
         $this->assertInstanceOf(\G4\DataMapper\Common\Identity::class, $this->identity->field('id')->lessThanOrEqual(1));
 
-        $this->setExpectedException('\Exception', 'Value can not be array');
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Value can not be array');
         $this->identity->field('name')->lessThanOrEqual([1]);
     }
 
     public function testLike()
     {
         $this->assertInstanceOf(\G4\DataMapper\Common\Identity::class, $this->identity->field('id')->like('this'));
 
-        $this->setExpectedException('\Exception', 'Value can not be array');
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Value can not be array');
         $this->identity->field('name')->like([1]);
     }
 
@@ -103,7 +109,8 @@ public function testNotEqual()
     {
         $this->assertInstanceOf(\G4\DataMapper\Common\Identity::class, $this->identity->field('id')->notEqual(1));
 
-        $this->setExpectedException('\Exception', 'Value can not be array');
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Value can not be array');
         $this->identity->field('name')->notEqual([1]);
     }
 
@@ -120,7 +127,8 @@ public function testField()
 
         $this->assertFalse($this->identity->isVoid());
 
-        $this->setExpectedException('\Exception', 'Incomplete field');
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Incomplete field');
         $this->identity->field('name');
     }
 
@@ -130,13 +138,15 @@ public function testFieldAlreadySet()
             ->field('id')
             ->equal(1);
 
-        $this->setExpectedException('\Exception', 'Field is already set');
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Field is already set');
         $this->identity->field('id');
     }
 
     public function testFieldIsNotDefined()
     {
-        $this->setExpectedException('\Exception', 'Field is not defined');
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Field is not defined');
         $this->identity->equal(1);
     }
 

diff --git a/tests/unit/src/Common/RangeValueTest.php b/tests/unit/src/Common/RangeValueTest.php
@@ -2,16 +2,16 @@
 
 use G4\DataMapper\Common\RangeValue;
 
-class RangeValueTest extends PHPUnit_Framework_TestCase
+class RangeValueTest extends \PHPUnit\Framework\TestCase
 {
     private $rangeValueObject;
 
-    protected function setup()
+    protected function setup(): void
     {
         $this->rangeValueObject = new RangeValue(5,18);
     }
 
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->rangeValueObject = null;
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,4 +27,4 @@ public function format() @@
                 ]
             ];
         }
-    }
+    }