Skip to content

fix(package): remove react-dom peer dependency#278

Merged
erquhart merged 1 commit intoget-convex:mainfrom
ramonclaudio:fix/remove-react-dom-peer-dep
Feb 27, 2026
Merged

fix(package): remove react-dom peer dependency#278
erquhart merged 1 commit intoget-convex:mainfrom
ramonclaudio:fix/remove-react-dom-peer-dep

Conversation

@ramonclaudio
Copy link
Copy Markdown
Contributor

@ramonclaudio ramonclaudio commented Feb 27, 2026 •
edited
Loading

Removes react-dom from peerDependencies.

There are zero imports of react-dom, ReactDOM, createRoot, hydrateRoot, flushSync, or createPortal across all 32 files in src/. None of the exports touch it, not /react, /nextjs, or /react-start.

The declaration was dead, generating peer dep warnings in bun and pnpm projects that don't use react-dom.

Summary by CodeRabbit

  • Chores
    • Updated peer dependency configuration by removing the react-dom requirement while maintaining React peer dependency support.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 27, 2026

@ramonclaudio is attempting to deploy a commit to the Convex Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 27, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The peer dependency entry for react-dom has been removed from package.json while maintaining the existing react peer dependency (^18.3.1 || ^19.0.0). This is a configuration-only modification with no logic or control flow changes.

Changes

Cohort / File(s) Summary
Package Configuration
package.json		 Removed react-dom from peerDependencies, retaining only the react version constraint.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 One less friend in the manifest file,
react-dom bid farewell with a smile.
Dependencies shrink, the burden grows light,
A simpler package.json—pure delight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The PR title accurately summarizes the main change: removing the react-dom peer dependency from package.json, which is the core objective of the changeset.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ramonclaudio ramonclaudio changed the title fix(package): remove spurious react-dom peer dependency fix(package): remove react-dom peer dependency Feb 27, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 27, 2026

Open in StackBlitz

npm i https://pkg.pr.new/get-convex/better-auth/@convex-dev/better-auth@278

commit: 65bcfa3

erquhart
erquhart approved these changes Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@erquhart erquhart merged commit 693be50 into get-convex:main Feb 27, 2026
6 of 7 checks passed
@ramonclaudio ramonclaudio deleted the fix/remove-react-dom-peer-dep branch April 8, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erquhart erquhart erquhart approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ramonclaudio @erquhart