Generate Sentry BOM by maciejwalkowiak · Pull Request #1486 · getsentry/sentry-java

maciejwalkowiak · 2021-05-25T10:11:20Z

📜 Description

Generate Sentry BOM

💡 Motivation and Context

Fixes #1484

💚 How did you test it?

📝 Checklist

I reviewed the submitted code
I added tests to verify the changes
I updated the docs if needed
No breaking changes

🔮 Next steps

Update release.kt script BOM to publish to Maven central.

Fixes #1484

maciejwalkowiak · 2021-05-25T10:12:46Z

Since I am not sure how to release the BOM file, the release.kt file will have to be updated likely when doing the release to find out if its enough to provide -Dfile property, or it has to be in -DpomFile etc.

codecov-commenter · 2021-05-25T10:30:22Z

Codecov Report

Merging #1486 (e7eb11d) into main (cdc87ea) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1486   +/-   ##
=========================================
  Coverage     75.93%   75.93%           
  Complexity     2004     2004           
=========================================
  Files           202      202           
  Lines          6943     6943           
  Branches        691      691           
=========================================
  Hits           5272     5272           
  Misses         1335     1335           
  Partials        336      336

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc87ea...e7eb11d. Read the comment docs.

marandaneto · 2021-05-26T07:04:37Z

I published it locally and tried using mavenLocal but it does not work

A problem occurred configuring project ':app'.

Could not resolve all dependencies for configuration ':app:debugCompileClasspath'.
Could not find io.sentry:sentry-bom:5.0.0-beta.5-SNAPSHOT.
Required by:
project :app
Could not find io.sentry:sentry:.
Required by:
project :app

the other thing is, release.kts won't work as it's a single pom and does not contain any javadoc, sources file, so we'd need to special case this project in that script.
the folder distributions also does not contain the sentry-bom subfolder, I think it's not generating the zip file, this should also be somehow solved.

marandaneto · 2021-05-28T09:23:22Z

just tried locally:

    implementation platform("io.sentry:sentry-bom:{version}")
    implementation "io.sentry:sentry-android"

and it worked, thanks @maciejwalkowiak

marandaneto · 2021-05-28T09:29:03Z

@maciejwalkowiak for docs getsentry/sentry-docs#3652

marandaneto · 2021-05-28T09:31:13Z

@maciejwalkowiak do you prefer opening a new PR for fixing the release script or this one?
it can be tested locally if temp. modifying settings.xml to maven local

maciejwalkowiak · 2021-05-31T07:08:37Z

How the settings should be modified?

marandaneto · 2021-05-31T07:31:47Z

How the settings should be modified?

ups sorry, release.kts, instead of using repositoryUrl as the cloud provider, set it to use maven local, so you can double check the deployment in ~/.m2/repository

gh-1484

maciejwalkowiak · 2021-06-23T15:38:04Z

@marandaneto updated the release script. Works well when I tested it locally.

marandaneto · 2021-06-24T08:01:39Z

scripts/release.kts


-            if (androidFile != null) {
-                file = androidFile.path
+            val bomFile = folder


@iker-barriocanal these changes will need to be updated in the craft release too, right?

CHANGELOG.md

maciejwalkowiak · 2021-06-24T08:52:31Z

@marandaneto should we merge it or not yet?

marandaneto · 2021-06-24T11:41:53Z

@marandaneto should we merge it or not yet?

I will test later but also need to check out #1486 (comment)
otherwise, the Draft of Craft will be broken already

marandaneto · 2021-07-14T11:57:32Z

@iker-barriocanal I am about to merge this, is craft ready to do a bom publish too?

marandaneto · 2021-07-14T11:59:33Z

scripts/release.kts

+                val command = "./mvnw gpg:sign-and-deploy-file " +
+                    "-Dfile=$pomFile " +
+                    "-DpomFile=$pomFile " +
+                    "-DrepositoryId=$repositoryId " +
+                    "-Durl=$repositoryUrl " +
+                    "--settings $settingsPath"


@iker-barriocanal how craft will handle this, as it's a different way of calling maven CLI for a bom (which is only a pom.xml) file?

bruno-garcia · 2021-07-21T22:02:44Z

An update, I merged the docs (getsentry/sentry-docs#3832) which I assume I'll need to revert. But to let y'all know we're just blocked on being able to release this. Hopefully @iker-barriocanal can help us out on this one too

iker-barriocanal · 2021-07-22T14:07:28Z

@bruno-garcia @marandaneto opened a PR to support this in Craft: getsentry/craft#270.

bruno-garcia · 2021-07-22T17:58:32Z

@bruno-garcia @marandaneto opened a PR to support this in Craft: getsentry/craft#270.

And it's merged! thanks Iker, I guess we're close to merging this one then

maciejwalkowiak added 2 commits May 25, 2021 12:10

Generate Sentry BOM

2abb5d7

Fixes #1484

Changelog.

f7f6d50

maciejwalkowiak marked this pull request as ready for review May 25, 2021 10:11

maciejwalkowiak requested review from bruno-garcia and marandaneto as code owners May 25, 2021 10:11

maciejwalkowiak and others added 4 commits May 26, 2021 13:47

Merge remote-tracking branch 'origin/main' into gh-1484

60c9529

fix conflict

030e8eb

fix

801170c

fix format

91741f3

marandaneto mentioned this pull request May 28, 2021

Document sentry-bom for Java and Android getsentry/sentry-docs#3652

Closed

marandaneto approved these changes May 28, 2021

View reviewed changes

maciejwalkowiak added 4 commits June 23, 2021 17:31

Generate different maven command to release a bom module.

bf425d5

Merge branch 'gh-1484' of https://github.com/getsentry/sentry-java into

6ed1d4c

gh-1484

Merge remote-tracking branch 'origin/main' into gh-1484

dd420f0

Bring back accidentally removed changelog entry.

dad436d

marandaneto reviewed Jun 24, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Changelog.

1693577

fix conflict

403c6e5

marandaneto reviewed Jul 14, 2021

View reviewed changes

bruno-garcia and others added 4 commits July 22, 2021 13:58

Merge branch 'main' into gh-1484

176370b

fix conflict

ac72d34

release: 5.1.0-beta.8

0f56092

Merge branch 'release/5.1.0-beta.8' into gh-1484

e7eb11d

marandaneto merged commit 754583c into main Jul 28, 2021

marandaneto deleted the gh-1484 branch July 28, 2021 12:28

Uh oh!

Conversation

maciejwalkowiak commented May 25, 2021

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

maciejwalkowiak commented May 25, 2021

Uh oh!

codecov-commenter commented May 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

marandaneto commented May 26, 2021

Uh oh!

marandaneto commented May 28, 2021

Uh oh!

marandaneto commented May 28, 2021

Uh oh!

marandaneto commented May 28, 2021

Uh oh!

maciejwalkowiak commented May 31, 2021

Uh oh!

marandaneto commented May 31, 2021

Uh oh!

maciejwalkowiak commented Jun 23, 2021

Uh oh!

marandaneto Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maciejwalkowiak commented Jun 24, 2021

Uh oh!

marandaneto commented Jun 24, 2021

Uh oh!

marandaneto commented Jul 14, 2021

Uh oh!

marandaneto Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bruno-garcia commented Jul 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iker-barriocanal commented Jul 22, 2021

Uh oh!

bruno-garcia commented Jul 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented May 25, 2021 •

edited

Loading

marandaneto Jul 14, 2021 •

edited

Loading

bruno-garcia commented Jul 21, 2021 •

edited

Loading