feat: Make AppStartState methods public for Hybrid SDKs & add some getters#1623
Closed
feat: Make AppStartState methods public for Hybrid SDKs & add some getters#1623
Conversation
Contributor
`Instructions and example for changelog`$
To the changelog entry, please add a link to this PR (consider a more descriptive message):` - Make AppStartState methods public for Hybrid SDKs & add some getters(#1623)
|
Contributor
|
not needed due to #1609 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Makes
getInstanceandisColdStartpublic onAppStartStateAdds
getAppStartEndandgetAppStartgetter methods to return the millis long values for Hybrid SDKs.💡 Motivation and Context
The methods were package-private and RN was not able to access them in getsentry/sentry-react-native#1696, also we would need to get the start and end timestamps.
💚 How did you test it?
Not tested as I never built the Java SDK before and don't know my way around yet.
📝 Checklist