fix: Remove appStartMillis and appStartEndMillis getters and make getAppStartTime public instead#1629
Merged
marandaneto merged 2 commits intomainfrom Jul 29, 2021
Merged
Conversation
marandaneto
approved these changes
Jul 29, 2021
Codecov Report
@@ Coverage Diff @@
## main #1629 +/- ##
=========================================
Coverage 75.93% 75.93%
Complexity 2004 2004
=========================================
Files 202 202
Lines 6943 6943
Branches 691 691
=========================================
Hits 5272 5272
Misses 1335 1335
Partials 336 336 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
React Native will now only need
getAppStartTimedue to reduced api.💡 Motivation and Context
Fixed due to misunderstanding that
appStartMillisandappStartEndMillisare unix timestamps.💚 How did you test it?
Have not built Android SDK before, relying on CI I guess.
📝 Checklist
🔮 Next steps
Make a release for RN
#skip-changelog (due to being internal api)