Fix: include feature flags in transaction trace context (#5023)#5733
Open
harryautomazione wants to merge 1 commit intogetsentry:masterfrom
Open
Fix: include feature flags in transaction trace context (#5023)#5733harryautomazione wants to merge 1 commit intogetsentry:masterfrom
harryautomazione wants to merge 1 commit intogetsentry:masterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Anthropic
Other
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #5023 where feature flags added to a Transaction (e.g. via
add_feature_flag) were not included in the transaction event payload sent to Sentry.Cause:
Transaction.get_trace_context()was overriding the"data"key returned bysuper().get_trace_context()which contained the flags, replacing it entirely withself._data(which only contained thread info).Fix:
Updated
Transaction.get_trace_context()to use.update()instead of complete overwrite of"data":This preserves the flags from the base
Spanclass and appends the thread information correctly.