Fixed DateTimePicker, and made names more intuitive#25
Fixed DateTimePicker, and made names more intuitive#25ghost1372 merged 9 commits intoghost1372:mainfrom
Conversation
Renamed SelectedDate to SelectedDateTime as calling a string a DateTime is confusing to the user this is a BREAKING change.
|
Hi @AlexanderBlackman Tnx for your Great PR. Regarding the following code, it is likely to end up in an infinite loop. Assigning a new value to SelectedTime triggers OnSelectedTimeChanged, which calls UpdateSelectedTime(). This method updates calendarWithClock.SelectedTime. do we need to Update SelectedDateTime/SelectedTime in SelectedTimeChanged? I haven't seen any problems with the tests before. |
|
Thank you for your suggestions, I only checked for loops via the debugger, as I didn't want to add a new test project. I assumed this wouldn't a infinite loop, as the event is triggered by CalendarWithClock's SelectedDateTime changing, and not DateTimePicker. But you are right, it might cause problems, so I've copied your try-finally isUpdating = false wrapping. When stepping through with debugger, MicaSystemBackdrop's OnDefaultSystemBackdropConfigurationChanged is called many many times, but I'm assuming that's work-in-progress, so I stayed clear. Sorry for the gitignore changes, I think it happened automatically when I just tried to change the DevWinUI.Controls project on its own as at the time I hadn't installed VS Preview and couldn't open slnx. I'll be more careful next time, this is the first time I've contributed on Github for years. |
|
LGTM🚀 |


Breaking
Renamed SelectedDate to SelectedDateTime and SelectedDateTime to SelectedDateTimeString. Calling a string a datetime would be very confusing.
Non-Breaking