Sourcery refactored master branch by sourcery-ai[bot] · Pull Request #1 · ghreat/practical-python

sourcery-ai · 2020-06-01T07:18:35Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

sourcery-ai · 2020-06-01T07:18:36Z

Solutions/1_10/mortgage.py

-    month = month + 1
+    month += 1
    principal = principal * (1+rate/12) - payment
-    total_paid = total_paid + payment
+    total_paid += payment

    if month >= extra_payment_start_month and month <= extra_payment_end_month:
-        principal = principal - extra_payment
-        total_paid = total_paid + extra_payment
+        principal -= extra_payment
+        total_paid += extra_payment

    print(month, round(total_paid,2), round(principal, 2))
-    
+


Lines 14-23 refactored with the following changes:

Replace assignment with augmented assignment

sourcery-ai · 2020-06-01T07:18:37Z

Solutions/1_33/pcost.py

-else:
-    filename = input('Enter a filename:')
-
+filename = sys.argv[1] if len(sys.argv) == 2 else input('Enter a filename:')


Lines 25-29 refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:37Z

Solutions/1_5/bounce.py

-bounce = 1
-while bounce <= 10:
-    height = height * (3/5)
+for bounce in range(1, 11):
+    height *= 3/5
    print(bounce, round(height, 4))
-    bounce += 1


Lines 4-8 refactored with the following changes:

Replace assignment with augmented assignment

Replace while with for

sourcery-ai · 2020-06-01T07:18:37Z

Solutions/2_16/pcost.py

-else:
-    filename = input('Enter a filename:')
-
+filename = sys.argv[1] if len(sys.argv) == 2 else input('Enter a filename:')


Lines 26-30 refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:37Z

Solutions/3_10/fileparse.py

-                record = dict(zip(headers, row))
-            else:
-                record = tuple(row)
+            record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:42Z

Solutions/6_15/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:42Z

Solutions/6_3/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:42Z

Solutions/6_3/portfolio.py


    def __contains__(self, name):
-        return any([s.name == name for s in self._holdings])
+        return any(s.name == name for s in self._holdings)


Function Portfolio.__contains__ refactored with the following changes:

Replace unneeded comprehension with generator

sourcery-ai · 2020-06-01T07:18:43Z

Solutions/6_3/portfolio.py

    @property
    def total_cost(self):
-        return sum([s.shares * s.price for s in self._holdings])
+        return sum(s.shares * s.price for s in self._holdings)


Function Portfolio.total_cost refactored with the following changes:

Replace unneeded comprehension with generator

sourcery-ai · 2020-06-01T07:18:43Z

Solutions/6_7/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:45Z

Solutions/6_7/portfolio.py


    def __contains__(self, name):
-        return any([s.name == name for s in self._holdings])
+        return any(s.name == name for s in self._holdings)


Function Portfolio.__contains__ refactored with the following changes:

Replace unneeded comprehension with generator

sourcery-ai · 2020-06-01T07:18:45Z

Solutions/6_7/portfolio.py

    @property
    def total_cost(self):
-        return sum([s.shares * s.price for s in self._holdings])
+        return sum(s.shares * s.price for s in self._holdings)


Function Portfolio.total_cost refactored with the following changes:

Replace unneeded comprehension with generator

sourcery-ai · 2020-06-01T07:18:46Z

Solutions/7_11/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:46Z

Solutions/7_4/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:46Z

Solutions/7_9/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:46Z

Solutions/8_1/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:46Z

Solutions/8_2/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:47Z

Solutions/9_3/porty-app/porty/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:47Z

Solutions/9_5/porty-app/porty/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression

sourcery-ai · 2020-06-01T07:18:47Z

Work/Data/stocksim.py

 def csv_record(fields):
-    s = '"%s",%0.2f,"%s","%s",%0.2f,%0.2f,%0.2f,%0.2f,%d' % tuple(fields)
-    return s
+    return '"%s",%0.2f,"%s","%s",%0.2f,%0.2f,%0.2f,%0.2f,%d' % tuple(fields)


Function csv_record refactored with the following changes:

Inline variable that is only used once

Fix missing new line

Refactored by Sourcery

7551e32

sourcery-ai bot commented Jun 1, 2020

View reviewed changes

ghreat pushed a commit that referenced this pull request Jul 7, 2020

Merge pull request #1 from bid0uille/bid0uille-patch-1

e71e7e0

Fix missing new line

Conversation

sourcery-ai bot commented Jun 1, 2020

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jun 1, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant