migrate to Go Module, use official compiler for cross-compiling#28
Merged
CatTail merged 3 commits intogit-hooks:masterfrom Dec 2, 2019
Merged
migrate to Go Module, use official compiler for cross-compiling#28CatTail merged 3 commits intogit-hooks:masterfrom
CatTail merged 3 commits intogit-hooks:masterfrom
Conversation
- Migrate to Go Module - Upgrade dependencies - Fix incorrect types in code - Use Go's native cross compiling mechanism
bb0e4b5 to
2b9dc26
Compare
CatTail
reviewed
Nov 21, 2019
|
|
||
| ## Supported Go versions | ||
|
|
||
| git-hooks supports the latest two Go version. (Currently 1.12 and 1.13) |
Member
There was a problem hiding this comment.
This is actually implementation details right? final user, which will use the binary directly do not care about which go version we use for development.
Contributor
Author
There was a problem hiding this comment.
Users may want to install git-hooks via go get, so I guess it's better to keep it.
We do not support Go 1.11 since [md2man](github.com/cpuguy83/go-md2man/v2/md2man) requires Go 1.12+.
CatTail
approved these changes
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.