Skip to content

Remove extra " from code example#18124

Closed
jamacku wants to merge 1 commit intogithub:mainfrom
jamacku:patch-2
Closed

Remove extra " from code example#18124
jamacku wants to merge 1 commit intogithub:mainfrom
jamacku:patch-2

Conversation

@jamacku
Copy link
Copy Markdown
Contributor

@jamacku jamacku commented May 23, 2022

Why:

It seems like there is extra " in the co-authored example.

What's being changed:

I've removed extra " from code example.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

It seems like there is extra `"` in the `co-authored` example.
@welcome
Copy link
Copy Markdown

welcome bot commented May 23, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 23, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@janiceilene
Copy link
Copy Markdown
Contributor

Thanks so much for opening a PR @jamacku! Looking at the page, I thought that looked like a typo too 😅 but then I realized that's the closing " for the one right at the beginning of the commit message in the first line.

I'm going to close this now.

Thanks so much for your interest in improving the docs 💖

@jamacku jamacku deleted the patch-2 branch May 23, 2022 12:43
@jamacku
Copy link
Copy Markdown
Contributor Author

jamacku commented May 23, 2022

Ohh, thanks @janiceilene, I somehow missed that 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants