Add support for PE RBAC token use with PuppetDB#169
Merged
kpaulisse merged 2 commits intogithub:masterfrom Dec 19, 2017
Merged
Conversation
Contributor
|
Hey @JohnLyman ! Thanks for the contribution of PE token authentication for PuppetDB. The code looks good to me, so I'm going to run this through our normal release process (a couple days of internal testing in our Puppet install within GitHub) and then push it out as a new minor release. 🎉 |
Author
|
Great, thanks! |
Merged
Contributor
|
Hey @JohnLyman - this is all merged, thanks! The e-mail address from your commit isn't associated with your GitHub account. If you associate that address, you'll show up in https://github.com/github/octocatalog-diff/graphs/contributors next time we update master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds the ability to use a PE RBAC token with PuppetDB.
Closes #156
Checklist
rakein your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:specor ignoring untestable sections of code with# :nocovcomments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests..gemfile into the vendor/cache directory.